Skip to content

[stable] Revert "Build shared LLVM lib for windows-gnullvm"#155283

Open
jieyouxu wants to merge 1 commit intorust-lang:stablefrom
jieyouxu:revert-gnullvm-link-shared-stable
Open

[stable] Revert "Build shared LLVM lib for windows-gnullvm"#155283
jieyouxu wants to merge 1 commit intorust-lang:stablefrom
jieyouxu:revert-gnullvm-link-shared-stable

Conversation

@jieyouxu
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu commented Apr 14, 2026 •
edited by rustbot
Loading

This reverts commit 1d1280a.

Looks like this causes problems (#155268) with certain LLVM bin tools not finding libLLVM on *-windows-gnullvm. This PR is a minimal revert to return us to known state to alleviate time pressure to investigate.

@jieyouxu
Revert "Build shared LLVM lib for windows-gnullvm"
9b3eeb3 
This reverts commit 1d1280a.

Looks like this causes problems with certain LLVM bin tools not finding
`libLLVM` on `*-windows-gnullvm`. This commit is a _minimal_ revert to
return us to known state to alleviate time pressure to investigate.
@rustbot

This comment was marked as outdated.

Sign in to view
@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against stable. Please double check that you specified the right target!

@jieyouxu
Copy link
Copy Markdown
Member Author

jieyouxu commented Apr 14, 2026

r? @Mark-Simulacrum
cc @mati865

@rustbot rustbot assigned Mark-Simulacrum and unassigned marcoieni Apr 14, 2026
jieyouxu
jieyouxu commented Apr 14, 2026
View reviewed changes
@jieyouxu jieyouxu force-pushed the revert-gnullvm-link-shared-stable branch from a449c41 to 9b3eeb3 Compare April 14, 2026 11:55
@jieyouxu jieyouxu changed the title [STABLE] Revert "Build shared LLVM lib for windows-gnullvm" [stable] Revert "Build shared LLVM lib for windows-gnullvm" Apr 14, 2026
@jieyouxu jieyouxu mentioned this pull request Apr 14, 2026
Open
@mati865
Copy link
Copy Markdown
Member

mati865 commented Apr 14, 2026

Thanks. Do not wait for the artifacts, building them just to be 100% sure rather than 99.9%.

@bors try jobs=dist-x86_64-llvm-mingw

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Apr 14, 2026
@bors
Auto merge of #155283 - jieyouxu:revert-gnullvm-link-shared-stable, r…
444fe5b 
…=<try>

[stable] Revert "Build shared LLVM lib for windows-gnullvm"


try-job: dist-x86_64-llvm-mingw
@jieyouxu jieyouxu added stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. stable-accepted Accepted for backporting to the compiler in the stable channel. and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Apr 14, 2026
ZuseZ4
ZuseZ4 reviewed Apr 14, 2026
View reviewed changes
src/ci/github-actions/jobs.yml
# i686 has no dedicated job, build it here because this job is fast
- name: dist-aarch64-llvm-mingw
env:
SCRIPT: python x.py dist bootstrap enzyme --include-default-paths
Copy link
Copy Markdown
Member

@ZuseZ4 ZuseZ4 Apr 14, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

Remove enzyme here and below. Otherwise it will fail, since (ATM) it requires dynamic linking

Copy link
Copy Markdown
Member

@mati865 mati865 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is enzyme built on stable? I thought it's nightly only.

Copy link
Copy Markdown
Member

@ZuseZ4 ZuseZ4 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nightly only, but that would mean the next nightly build would still fail, even if a stable build in this config works, or?

Copy link
Copy Markdown
Member

@mati865 mati865 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is targeting stable branch exclusively. LLVM DLL remains enabled on main branch.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026

☀️ Try build successful (CI)
Build commit: 444fe5b (444fe5bd5379d825792af9dec410925ae17e5c21, parent: 6efb623524553af1f2456642f069a6f5b8abc1dd)

@mati865
Copy link
Copy Markdown
Member

mati865 commented Apr 14, 2026

Installed and tested using:

❯ rustup-toolchain-install-master -n revert 444fe5bd5379d825792af9dec410925ae17e5c21 -c llvm-tools
...

❯ /c/Users/Mateusz/.rustup/toolchains/revert/lib/rustlib/x86_64-pc-windows-gnullvm/bin/llvm-as --version
LLVM (http://llvm.org/):
  LLVM version 22.1.2-rust-1.95.0-stable
  Optimized build.

Whereas on nightly this looks like this:

❯ /c/Users/Mateusz/.rustup/toolchains/nightly-x86_64-pc-windows-gnullvm/lib/rustlib/x86_64-pc-windows-gnullvm/bin/rust-lld
C:/Users/Mateusz/.rustup/toolchains/nightly-x86_64-pc-windows-gnullvm/lib/rustlib/x86_64-pc-windows-gnullvm/bin/rust-lld.exe: error while loading shared libraries: api-ms-win-crt-utility-l1-1-0.dll: cannot open shared object file: No such file or directory

❯ ntldd /c/Users/Mateusz/.rustup/toolchains/nightly-x86_64-pc-windows-gnullvm/lib/rustlib/x86_64-pc-windows-gnullvm/bin/rust-lld
        libLLVM-22-rust-1.97.0-nightly.dll => not found
        KERNEL32.dll => C:\WINDOWS\SYSTEM32\KERNEL32.dll (0x0000025408200000)
        libunwind.dll => C:\Users\Mateusz\.rustup\toolchains\nightly-x86_64-pc-windows-gnullvm\lib\rustlib\x86_64-pc-windows-gnullvm\bin\libunwind.dll (0x0000025407830000)

So, indeed the issue is fixed.

@Mark-Simulacrum
Copy link
Copy Markdown
Member

Mark-Simulacrum commented Apr 14, 2026

@bors r+ rollup=never p=100

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026

📌 Commit 9b3eeb3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026 •
edited
Loading

⌛ Testing commit 9b3eeb3 with merge 5980761...

Workflow: https://github.com/rust-lang/rust/actions/runs/24419883290

rust-bors bot pushed a commit that referenced this pull request Apr 14, 2026
@bors
Auto merge of #155283 - jieyouxu:revert-gnullvm-link-shared-stable, r…
5980761 
…=Mark-Simulacrum

[stable] Revert "Build shared LLVM lib for windows-gnullvm"

This reverts commit 1d1280a.

Looks like this causes problems (#155268) with certain LLVM bin tools not finding `libLLVM` on `*-windows-gnullvm`. This PR is a _minimal_ revert to return us to known state to alleviate time pressure to investigate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mati865 mati865 mati865 left review comments

@ZuseZ4 ZuseZ4 ZuseZ4 left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jieyouxu @rustbot @mati865 @Mark-Simulacrum @ZuseZ4 @marcoieni