Skip to content

[win] Fix truncated unwinds for Arm64 Windows#153202

Open
dpaoliello wants to merge 1 commit intorust-lang:mainfrom
dpaoliello:arm64unwind
Open

[win] Fix truncated unwinds for Arm64 Windows#153202
dpaoliello wants to merge 1 commit intorust-lang:mainfrom
dpaoliello:arm64unwind

Conversation

@dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented Feb 27, 2026

Panic backtraces on ARM64 Windows are truncated because Rust's LLVM configuration sets NoTrapAfterNoreturn = true, which suppresses the generation of brk #0x1 (trap) instructions after calls to noreturn functions. Without this trap instruction, the return address from a noreturn call points past the end of the calling function into an unrelated function, causing RtlLookupFunctionEntry to return the wrong unwind information, which terminates the stack walk prematurely.

In general, NoTrapAfterNoreturn = true is recommended against for Windows, since we have seen security vulnerabilities in the past where an attacker has managed to return from a noreturn function, or the function wasn't actually noereturn, resulting in executing whatever was after the call.

This change disables setting NoTrapAfterNoreturn = true for Windows.

Fixes #140489

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 27, 2026

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @cuviper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic backtrace on Arm64 Windows is truncated

3 participants