[win] Fix truncated unwinds for Arm64 Windows#153202
Open
dpaoliello wants to merge 1 commit intorust-lang:mainfrom
Open
[win] Fix truncated unwinds for Arm64 Windows#153202dpaoliello wants to merge 1 commit intorust-lang:mainfrom
dpaoliello wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @cuviper rustbot has assigned @cuviper. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panic backtraces on ARM64 Windows are truncated because Rust's LLVM configuration sets
NoTrapAfterNoreturn = true, which suppresses the generation ofbrk #0x1(trap) instructions after calls tonoreturnfunctions. Without this trap instruction, the return address from anoreturncall points past the end of the calling function into an unrelated function, causingRtlLookupFunctionEntryto return the wrong unwind information, which terminates the stack walk prematurely.In general,
NoTrapAfterNoreturn = trueis recommended against for Windows, since we have seen security vulnerabilities in the past where an attacker has managed to return from a noreturn function, or the function wasn't actually noereturn, resulting in executing whatever was after the call.This change disables setting
NoTrapAfterNoreturn = truefor Windows.Fixes #140489