Update path separators to be available in const context#153196
Open
MikkelPaulson wants to merge 2 commits intorust-lang:mainfrom
Open
Update path separators to be available in const context#153196MikkelPaulson wants to merge 2 commits intorust-lang:mainfrom
MikkelPaulson wants to merge 2 commits intorust-lang:mainfrom
Conversation
Change reference to imported MAIN_SEP_STR to local MAIN_SEPARATOR_STR, removing an unnecessary import.
* consolidate various representations of separators in std::sys::path
into a single macro_rules invocation per platform to save
transcription errors
* make `std::path::is_separator()` const
* new constants `std::path::{SEPARATORS, SEPARATORS_STR}`
rustbot
added
S-waiting-on-review
Collaborator
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
4 tasks
joboet
approved these changes
Feb 28, 2026
Comment on lines
+4
to
+5
| // FIXME(const_array): this can be done much more cleanly at compile time without a macro once | ||
| // array::from_fn and/or array::map are stabilized |
Member
There was a problem hiding this comment.
I think we'd still want the macro in this case because it makes the item definitions simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #153106
This makes platform-dependent secondary path separators available in const context (ie. at compile time). The platform definitions have also been consolidated behind a common macro to prevent transcription errors, whereas previously they were defined 3-4 times per platform.
Questions
I've manually verified that this compiles against each platform. It seems like no unit tests should be required for this change; is that correct?