don't emit unused_results lint for tuples of "trivial" types #153191
Open
WaffleLapkin wants to merge 2 commits intorust-lang:mainfrom
Open
don't emit unused_results lint for tuples of "trivial" types #153191WaffleLapkin wants to merge 2 commits intorust-lang:mainfrom
unused_results lint for tuples of "trivial" types #153191WaffleLapkin wants to merge 2 commits intorust-lang:mainfrom
Conversation
621c007 to
8958cb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @jdonszelmann
Fixes #153144.
So it turns out #153018 had a sneaky behavior change in the way tuples are handled and the old behavior wasn't tested.
Consider these tuples:
Neither of them is
must_use, so they are potential candidates forunused_results. So the question is whatever said tuples are considered "trivial" and thus if they end up emittingunused_resultsor not.Here is a comparison table between PRs:
tuples are trivial if any of their fields are trivial
tuples are never trivial
tuples are trivial if all of their fields are trivial