Rollup of 10 pull requests #150726
Merged
Rollup of 10 pull requests #150726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as 147495, just keeping it up-to-date.
This was recently fixed upstream in LLVM, so we update our default layout to match. @rustbot label: +llvm-main
This way using pidfd_spawnp won't have to rely on procfs, avoiding an unpleasant edge-case
where the child is spawned but we can't get the pid.
And `pidfd.{try_}wait` will be able to return the exit status even after a process has been reaped.
At least on newer kernels.
`lower_anon_const_to_const_arg_direct` to `lower_anon_const_to_const_arg_and_alloc` and `lower_anon_const_to_const_arg`
…rait, r=jdonszelmann Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items https://github.com/rust-lang/rust/blob/master/compiler/rustc_passes/src/dead.rs#L360-L361 won't insert assoc items into the live set, so that impl items cannot be marked live. This PR lets impls and impl items can inherit lint levels of the corresponding traits and trait items. Fixes rust-lang#144060 r? ````@petrochenkov````
…nikic rustc_codegen_llvm: update alignment for double on AIX This was recently fixed upstream in LLVM, so we update our default layout to match. ````@rustbot```` label: +llvm-main
Refactor function names of `rustc_ast_lowering` close: rust-lang#150062 I'll rebase after rust-lang#149114 is merged. Would it be better to change `lower_const_path_to_const_arg` → `lower_const_path_to_const_arg_and_intern`, `lower_array_length_to_const_arg` → `lower_array_length_to_const_arg_and_intern`? r? ``@lcnr``
use PIDFD_GET_INFO ioctl when available
This way using pidfd_spawnp won't have to rely on procfs, avoiding an unpleasant edge-case where the child is spawned but we can't get the pid. And pidfd.{try_}wait will be able to return the exit status even after a process has been reaped. At least on newer kernels.
Tracking issue: rust-lang#82971
THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern` The code in `thir::cx::block` was the only code outside of `thir::pattern` that created `thir::Pat` nodes. Moving it makes the signature of `pat_from_hir` a bit messier, but ensures that all `thir::Pat` creation occurs in one module. That will be useful when trying to change `thir::Pat`, e.g. by adding fields to remove the need for wrapper nodes. There should be no change to compiler output.
MGCA: pretty printing for struct expressions and tuple calls
not sure
1. if there any tests that i need to adjust
2. if i should add any test for it
3. if humanity has come up with anything better than checking if that's first iteration or not with flag when printing sequences with separator
in case there is no tests for it and i dont have to add any, there is a demonstration of this ✨ pretty ✨ printing (this is output from `-Z unpretty=hir`)
```
fn test_errors<const N:
usize>() {
// accepts_enum::<{ None::<u32> }>();
accepts_point::<Point1 { a: N, b: N }>();
accepts_point::<Point(N, N)>();
}
```
btw it does not print const block
for this
```
accepts_point::<{ Point1 { a: const {N + 1}, b: N } }>();
```
it will print
```
accepts_point::<Point1 { a: { N + 1 }, b: N }>();
```
not sure if we want to print const blocks or not
r? BoxyUwU
Improve comment clarity in candidate_may_shadow I think this should be the right correction, but I'm not sure.
…-ld, r=Mark-Simulacrum Update wasm-component-ld Same as rust-lang#147495, just keeping it up-to-date.
…ce, r=BoxyUwU Fix ICE when transmute Assume field is invalid This PR fixes an internal compiler error in `rustc_transmute` where initializing an `Assume` field (like `alignment`) with a non-scalar constant (like a struct) caused a panic. The fix updates `from_const` to use `try_to_scalar()` instead of assuming the value is always a leaf. It now gracefully returns `None` for invalid types, allowing the compiler to report standard "missing field initialiser" errors instead of crashing. Fixes rust-lang#150506
Enable merge queue in new bors We can proactively merge this now. Note that new bors will still default to being "paused" and not running the merge queue, after being restarted: - https://github.com/rust-lang/bors/blob/e1fafaa3b89c225069fa2aa1193096e1d66075c3/src/bors/merge_queue.rs#L101 - https://github.com/rust-lang/bors/blob/bf491ee40d1fc877af273f2ec92a2968dee8cdb7/src/github/api/mod.rs#L159 - rust-lang#112049 (comment) We can resume it quickly with a command, to test how the merging functionality behaves.
rustbot
added
A-LLVM
Contributor
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 74fd7516da In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 74fd751 (parent) -> 4d73a00 (this PR) Test differencesShow 10 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4d73a008eaf6ba3ca067a3221e5c00602e33a5f2 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (4d73a00): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.921s -> 473.709s (-0.04%) |
This was referenced Jan 6, 2026
Contributor
Author
|
Guessing this is #144113, rust-timer running at that PR |
JonathanBrouwer
added
the
perf-regression-triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
dead_codelint level of the corresponding traits and trait items #144113 (Impls and impl items inheritdead_codelint level of the corresponding traits and trait items)rustc_ast_lowering#150122 (Refactor function names ofrustc_ast_lowering)thir::Patcreation intorustc_mir_build::thir::pattern#150670 (THIR pattern building: Move allthir::Patcreation intorustc_mir_build::thir::pattern)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup