Unix implementation for stdio set/take/replace #150668

the8472 · 2026-01-04T10:36:23Z

Tracking issue: #150667
ACP: rust-lang/libs-team#500

rustbot · 2026-01-04T10:36:28Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

library/std/src/os/unix/io/mod.rs

Mark-Simulacrum

r=me if you want to move these to tracking issue open questions

View changes since this review

library/std/src/os/unix/io/mod.rs

bjorn3 · 2026-01-04T15:56:16Z

library/std/src/os/unix/io/mod.rs

+fn replace_stdio_fd(this: BorrowedFd<'_>, other: OwnedFd) -> io::Result<()> {
+    cfg_select! {
+        not(any(
+            target_arch = "wasm32",


wasip1 supports fd_renumber which is like dup2 except moving the fd rather than duplicating it.

But wasip1 doesn't implement try_clone_to_owned, so replace and take won't work. But ok, we can still support set with that.

the8472 · 2026-01-05T08:12:07Z

@bors r=Mark-Simulacrum

bors · 2026-01-05T08:12:10Z

📌 Commit 0f5cf5e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Rollup of 3 pull requests Successful merges: - #150412 (use PIDFD_GET_INFO ioctl when available) - #150668 (Unix implementation for stdio set/take/replace) - #150702 (`rust-analyzer` subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Rollup of 8 pull requests Successful merges: - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items) - #149880 (rustc_codegen_llvm: update alignment for double on AIX) - #150668 (Unix implementation for stdio set/take/replace) - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`) - #150695 (MGCA: pretty printing for struct expressions and tuple calls ) - #150698 (Improve comment clarity in candidate_may_shadow) - #150706 (Update wasm-component-ld) - #150710 (Update libc dependency of std) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2026-01-06T05:59:36Z

I don't think this is responsible for rollup failure in #150718 (comment), but let's double-check:

@bors try jobs=dist-ohos-armv7

Unix implementation for stdio set/take/replace try-job: dist-ohos-armv7

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

rust-bors · 2026-01-06T07:28:11Z

☀️ Try build successful (CI)
Build commit: 5c50261 (5c502615103173df967ba3fbfaf3c816b124061f, parent: da476f1942868cdf94ed88b01ea31170cfe95047)

Rollup of 8 pull requests Successful merges: - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items) - #149880 (rustc_codegen_llvm: update alignment for double on AIX) - #150412 (use PIDFD_GET_INFO ioctl when available) - #150668 (Unix implementation for stdio set/take/replace) - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`) - #150695 (MGCA: pretty printing for struct expressions and tuple calls ) - #150698 (Improve comment clarity in candidate_may_shadow) - #150706 (Update wasm-component-ld) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2026-01-06T13:34:56Z

Failed in rollup? #150719 (comment)

@bors r-
@bors try jobs=dist-various-1

Unix implementation for stdio set/take/replace try-job: dist-various-1

rust-bors · 2026-01-06T14:39:50Z

💔 Test for 23d81dc failed: CI. Failed jobs:

try - dist-various-1 (web logs, enhanced plaintext logs)

the8472 · 2026-01-06T15:59:09Z

@bors try jobs=dist-various-1

Unix implementation for stdio set/take/replace try-job: dist-various-1

rust-bors · 2026-01-06T17:22:07Z

☀️ Try build successful (CI)
Build commit: b6f4170 (b6f41707b2cb8e4ccd4e33e3620391225b238cbc, parent: 74fd7516dac6e7be0e561dddb9bee4e860598f07)

the8472 · 2026-01-06T20:42:11Z

@bors r=Mark-Simulacrum rollup=iffy

bors · 2026-01-06T20:42:14Z

📌 Commit 1cd8752 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

…uwer Rollup of 3 pull requests Successful merges: - #150094 (`c_variadic`: provide our own `va_arg` implementation for more targets) - #150569 (Ensure that static initializers are acyclic for NVPTX) - #150668 (Unix implementation for stdio set/take/replace) r? `@ghost` `@rustbot` modify labels: rollup

JonathanBrouwer · 2026-01-07T06:06:08Z

@bors r-
#150742 (comment)

rustbot assigned Mark-Simulacrum Jan 4, 2026

rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 4, 2026

This comment has been minimized.

Sign in to view

the8472 force-pushed the stdio-swap branch from aa5e351 to 3daed94 Compare January 4, 2026 11:29

bjorn3 reviewed Jan 4, 2026

View reviewed changes

library/std/src/os/unix/io/mod.rs Outdated Show resolved Hide resolved

Mark-Simulacrum reviewed Jan 4, 2026

View reviewed changes

library/std/src/os/unix/io/mod.rs Outdated Show resolved Hide resolved

library/std/src/os/unix/io/mod.rs Show resolved Hide resolved

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

bjorn3 reviewed Jan 4, 2026

View reviewed changes

the8472 force-pushed the stdio-swap branch from 3daed94 to 0f5cf5e Compare January 5, 2026 03:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 5, 2026

Rollup merge of rust-lang#150668 - the8472:stdio-swap, r=Mark-Simulacrum

7b53217

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

JonathanBrouwer mentioned this pull request Jan 5, 2026

Rollup of 4 pull requests #150715

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2026

Rollup merge of rust-lang#150668 - the8472:stdio-swap, r=Mark-Simulacrum

53b07ad

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

matthiaskrgr mentioned this pull request Jan 5, 2026

Rollup of 3 pull requests #150716

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 6, 2026

Rollup merge of rust-lang#150668 - the8472:stdio-swap, r=Mark-Simulacrum

a1ce839

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Zalathar mentioned this pull request Jan 6, 2026

Rollup of 8 pull requests #150718

Closed

rust-bors bot added a commit that referenced this pull request Jan 6, 2026

Auto merge of #150668 - the8472:stdio-swap, r=<try>

5c50261

Unix implementation for stdio set/take/replace try-job: dist-ohos-armv7

This comment has been minimized.

Sign in to view

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 6, 2026

Rollup merge of rust-lang#150668 - the8472:stdio-swap, r=Mark-Simulacrum

c097ef3

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Zalathar mentioned this pull request Jan 6, 2026

Rollup of 8 pull requests #150719

Closed

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 6, 2026

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 6, 2026

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 6, 2026

rust-bors bot added a commit that referenced this pull request Jan 6, 2026

Auto merge of #150668 - the8472:stdio-swap, r=<try>

23d81dc

Unix implementation for stdio set/take/replace try-job: dist-various-1

This comment has been minimized.

Sign in to view

Unix implementation for stdio set/take/replace

1cd8752

the8472 force-pushed the stdio-swap branch from 0f5cf5e to 1cd8752 Compare January 6, 2026 15:57

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jan 6, 2026

Auto merge of #150668 - the8472:stdio-swap, r=<try>

b6f4170

Unix implementation for stdio set/take/replace try-job: dist-various-1

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 6, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 6, 2026

Rollup merge of rust-lang#150668 - the8472:stdio-swap, r=Mark-Simulacrum

72cb153

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

JonathanBrouwer mentioned this pull request Jan 6, 2026

Rollup of 3 pull requests #150742

Closed

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 7, 2026

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 7, 2026

Uh oh!

Unix implementation for stdio set/take/replace #150668

Are you sure you want to change the base?

Unix implementation for stdio set/take/replace #150668

Conversation

the8472 commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Mark-Simulacrum left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bjorn3 Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

the8472 Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

the8472 Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

the8472 commented Jan 5, 2026

Uh oh!

bors commented Jan 5, 2026

Uh oh!

Zalathar commented Jan 6, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 6, 2026

Uh oh!

Zalathar commented Jan 6, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 6, 2026

Uh oh!

This comment has been minimized.

the8472 commented Jan 6, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 6, 2026

Uh oh!

the8472 commented Jan 6, 2026

Uh oh!

bors commented Jan 6, 2026

Uh oh!

JonathanBrouwer commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Mark-Simulacrum left a comment •

edited by rustbot

Loading