compiletest: Support revisions in debuginfo (read: debugger) tests #150201
+43
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests This not only reduces code duplication already, it also gives us revision parsing for free which we need in upcoming commits. Long term we should probably use newtypes to avoid mixing up zero-based and one-based line numbers. For now, rename var name to `zero_based_line_no` to make things slightly clearer. `check_lines` uses zero-based, but `DirectiveLine` use one-based.
…, `no-SingleUseConsts-mir-pass` To prevent the test from regressing both with and without `SingleUseConsts` MIR pass.
rustbot
added
A-compiletest
This comment has been minimized.
This comment has been minimized.
Enselic
force-pushed
the
debugger-tests-revisions-2
branch
from
e25c6c9 to
a63fee8
Compare
This was referenced Dec 20, 2025
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 21, 2025
tests/debuginfo/function-arg-initialization.rs: Stop disabling SingleUseConsts MIR pass This test passes locally for me. Let's see if it passes CI too. Discovered while I worked on rust-lang#150201. CC rust-lang#128945
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 21, 2025
tests/debuginfo/function-arg-initialization.rs: Stop disabling SingleUseConsts MIR pass This test passes locally for me. Let's see if it passes CI too. Discovered while I worked on rust-lang#150201. CC rust-lang#128945
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 21, 2025
tests/debuginfo/function-arg-initialization.rs: Stop disabling SingleUseConsts MIR pass This test passes locally for me. Let's see if it passes CI too. Discovered while I worked on rust-lang#150201. CC rust-lang#128945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And start using revisions in
tests/debuginfo/macro-stepping.rsto prevent regressing both with and withoutSingleUseConstsMIR pass.I recommend commit-by-commit review.
TODO
LineNonewtype to avoid+1magic here and there #150205 once merged so we don't have to add another "+ 1".CC
CC @Zalathar since you might have opinions about that I expose a helper function to reduce duplication
CC @saethlin since this is what we will use for
tests/debuginfo/basic-stepping.rsin #147426 (in the same way I use it intests/debuginfo/macro-stepping.rshere)