Skip to content

Conversation

@jhpratt
Copy link
Member

@jhpratt jhpratt commented Dec 17, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Bryntet and others added 10 commits December 16, 2025 20:29
…generic_args, r=jonathanbrouwer,jdonszelmann

Port `#[rustc_legacy_const_generics]` to use attribute parser

Small PR that ports the `#[rustc_legacy_const_generics]` to use the new attribute parser!

r? JonathanBrouwer
autodiff: emit an error if we fail to find libEnzyme

Tested manually by moving libEnzyme-21.so away. We should adjust the error msg. once we have the component up.

It's the first usage within rustc of this experimental feature, but afaik we're open to dogfooding those for test purpose, right?

r? ``@Kobzol``
Partially revert rust-lang#147888 and print warning if LLVM CMake dir is missing when building Enzyme

Partially reverts rust-lang#147888, Enzyme cannot be build with `download-ci-llvm = true`.

r? ``@ZuseZ4``
…rouwer

Port #[no_link] to use attribute parser

Adds `#[no_link]` to the attribute parser, as well as adds tests making sure to FCW warn on `field`, `arm`, and `macrodef `
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 17, 2025
@jhpratt
Copy link
Member Author

jhpratt commented Dec 17, 2025

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Dec 17, 2025

📌 Commit 656d4e8 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2025
@bors
Copy link
Collaborator

bors commented Dec 17, 2025

⌛ Testing commit 656d4e8 with merge ec6f622...

@bors
Copy link
Collaborator

bors commented Dec 17, 2025

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing ec6f622 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2025
@bors bors merged commit ec6f622 into rust-lang:main Dec 17, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 17, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150000 Port #[rustc_legacy_const_generics] to use attribute pars… 2a11f0c18b3c92889b83993e6731438b320fae03 (link)
#150060 autodiff: emit an error if we fail to find libEnzyme 68340bad984186fe2a4b1cee01fc9b5f397f4a38 (link)
#150070 Partially revert #147888 and print warning if LLVM CMake di… 71bd1395bfba3cbfc3fcac51ace27d91e6ce244d (link)
#150072 Port #[no_link] to use attribute parser 2eb003422a5a92ff48abe7e6ed82e3819982b52f (link)

previous master: 2dc30247c5

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2dc3024 (parent) -> ec6f622 (this PR)

Test differences

Show 472 test diffs

Stage 0

  • errors::verify_passes_attr_application_struct_union_80: [missing] -> pass (J1)
  • errors::verify_passes_const_stable_not_stable_94: [missing] -> pass (J1)
  • errors::verify_passes_const_stable_not_stable_97: pass -> [missing] (J1)
  • errors::verify_passes_custom_mir_phase_requires_dialect_112: [missing] -> pass (J1)
  • errors::verify_passes_deprecated_annotation_has_no_effect_52: pass -> [missing] (J1)
  • errors::verify_passes_doc_fake_variadic_not_valid_17: [missing] -> pass (J1)
  • errors::verify_passes_doc_fake_variadic_not_valid_18: pass -> [missing] (J1)
  • errors::verify_passes_doc_inline_conflict_20: [missing] -> pass (J1)
  • errors::verify_passes_doc_inline_conflict_21: pass -> [missing] (J1)
  • errors::verify_passes_doc_keyword_attribute_empty_mod_15: [missing] -> pass (J1)
  • errors::verify_passes_doc_keyword_attribute_empty_mod_16: pass -> [missing] (J1)
  • errors::verify_passes_doc_keyword_attribute_not_mod_17: pass -> [missing] (J1)
  • errors::verify_passes_duplicate_eii_impls_120: pass -> [missing] (J1)
  • errors::verify_passes_eii_impl_not_function_114: [missing] -> pass (J1)
  • errors::verify_passes_extern_main_75: pass -> [missing] (J1)
  • errors::verify_passes_feature_previously_declared_73: pass -> [missing] (J1)
  • errors::verify_passes_feature_stable_twice_69: [missing] -> pass (J1)
  • errors::verify_passes_has_incoherent_inherent_impl_25: [missing] -> pass (J1)
  • errors::verify_passes_ignored_attr_with_macro_9: pass -> [missing] (J1)
  • errors::verify_passes_ineffective_unstable_impl_101: pass -> [missing] (J1)
  • errors::verify_passes_inline_ignored_for_exported_79: pass -> [missing] (J1)
  • errors::verify_passes_lang_item_fn_with_target_feature_55: [missing] -> pass (J1)
  • errors::verify_passes_lang_item_on_incorrect_target_56: [missing] -> pass (J1)
  • errors::verify_passes_layout_abi_59: [missing] -> pass (J1)
  • errors::verify_passes_layout_homogeneous_aggregate_65: pass -> [missing] (J1)
  • errors::verify_passes_missing_const_stab_attr_88: [missing] -> pass (J1)
  • errors::verify_passes_missing_lang_item_53: [missing] -> pass (J1)
  • errors::verify_passes_missing_panic_handler_54: pass -> [missing] (J1)
  • errors::verify_passes_missing_stability_attr_90: pass -> [missing] (J1)
  • errors::verify_passes_object_lifetime_err_80: pass -> [missing] (J1)
  • errors::verify_passes_panic_unwind_without_std_52: [missing] -> pass (J1)
  • errors::verify_passes_repr_align_should_be_align_static_111: [missing] -> pass (J1)
  • errors::verify_passes_repr_conflicting_38: pass -> [missing] (J1)
  • errors::verify_passes_rustc_allow_const_fn_unstable_38: [missing] -> pass (J1)
  • errors::verify_passes_rustc_const_stable_indirect_pairing_104: pass -> [missing] (J1)
  • errors::verify_passes_rustc_legacy_const_generics_index_32: pass -> [missing] (J1)
  • errors::verify_passes_rustc_legacy_const_generics_index_exceed_33: pass -> [missing] (J1)
  • errors::verify_passes_trait_impl_const_stable_89: [missing] -> pass (J1)
  • errors::verify_passes_transparent_incompatible_85: pass -> [missing] (J1)
  • errors::verify_passes_unexportable_type_in_interface_110: pass -> [missing] (J1)
  • errors::verify_passes_unexportable_type_repr_109: pass -> [missing] (J1)
  • errors::verify_passes_unknown_external_lang_item_50: [missing] -> pass (J1)
  • errors::verify_passes_unknown_lang_item_60: pass -> [missing] (J1)
  • errors::verify_passes_unsupported_attributes_in_where_102: [missing] -> pass (J1)
  • errors::verify_passes_unused_duplicate_44: [missing] -> pass (J1)
  • errors::verify_passes_useless_assignment_78: pass -> [missing] (J1)

Stage 1

  • errors::verify_passes_abi_invalid_attribute_67: [missing] -> pass (J0)
  • errors::verify_passes_abi_of_65: [missing] -> pass (J0)
  • errors::verify_passes_abi_of_68: pass -> [missing] (J0)
  • errors::verify_passes_attr_application_enum_78: [missing] -> pass (J0)
  • errors::verify_passes_attr_application_struct_82: pass -> [missing] (J0)
  • errors::verify_passes_debug_visualizer_unreadable_40: pass -> [missing] (J0)
  • errors::verify_passes_deprecated_annotation_has_no_effect_49: [missing] -> pass (J0)
  • errors::verify_passes_deprecated_annotation_has_no_effect_52: pass -> [missing] (J0)
  • errors::verify_passes_doc_alias_bad_location_13: [missing] -> pass (J0)
  • errors::verify_passes_doc_alias_not_an_alias_14: [missing] -> pass (J0)
  • errors::verify_passes_doc_fake_variadic_not_valid_17: [missing] -> pass (J0)
  • errors::verify_passes_doc_inline_only_use_22: pass -> [missing] (J0)
  • errors::verify_passes_doc_masked_not_extern_crate_self_24: pass -> [missing] (J0)
  • errors::verify_passes_doc_masked_only_extern_crate_22: [missing] -> pass (J0)
  • errors::verify_passes_doc_masked_only_extern_crate_23: pass -> [missing] (J0)
  • errors::verify_passes_doc_search_unbox_invalid_19: [missing] -> pass (J0)
  • errors::verify_passes_duplicate_diagnostic_item_in_crate_61: pass -> [missing] (J0)
  • errors::verify_passes_duplicate_feature_err_95: pass -> [missing] (J0)
  • errors::verify_passes_eii_fn_with_track_caller_115: [missing] -> pass (J0)
  • errors::verify_passes_eii_fn_with_track_caller_118: pass -> [missing] (J0)
  • errors::verify_passes_eii_without_impl_116: [missing] -> pass (J0)
  • errors::verify_passes_feature_previously_declared_73: pass -> [missing] (J0)
  • errors::verify_passes_lang_item_fn_with_target_feature_55: [missing] -> pass (J0)
  • errors::verify_passes_lang_item_fn_with_target_feature_58: pass -> [missing] (J0)
  • errors::verify_passes_lang_item_fn_with_track_caller_54: [missing] -> pass (J0)
  • errors::verify_passes_layout_abi_59: [missing] -> pass (J0)
  • errors::verify_passes_layout_abi_62: pass -> [missing] (J0)
  • errors::verify_passes_layout_of_66: pass -> [missing] (J0)
  • errors::verify_passes_layout_size_64: pass -> [missing] (J0)
  • errors::verify_passes_macro_export_on_decl_macro_41: [missing] -> pass (J0)
  • errors::verify_passes_macro_only_attribute_39: pass -> [missing] (J0)
  • errors::verify_passes_missing_const_err_93: [missing] -> pass (J0)
  • errors::verify_passes_missing_const_err_96: pass -> [missing] (J0)
  • errors::verify_passes_missing_const_stab_attr_88: [missing] -> pass (J0)
  • errors::verify_passes_must_not_suspend_28: pass -> [missing] (J0)
  • errors::verify_passes_no_link_30: pass -> [missing] (J0)
  • errors::verify_passes_non_exported_macro_invalid_attrs_45: pass -> [missing] (J0)
  • errors::verify_passes_repr_align_should_be_align_static_111: [missing] -> pass (J0)
  • errors::verify_passes_repr_conflicting_36: pass -> [missing] (J0)
  • errors::verify_passes_repr_conflicting_38: pass -> [missing] (J0)
  • errors::verify_passes_rustc_allow_const_fn_unstable_41: pass -> [missing] (J0)
  • errors::verify_passes_rustc_legacy_const_generics_index_30: [missing] -> pass (J0)
  • errors::verify_passes_rustc_legacy_const_generics_index_exceed_31: [missing] -> pass (J0)
  • errors::verify_passes_rustc_lint_opt_deny_field_access_47: [missing] -> pass (J0)
  • errors::verify_passes_rustc_lint_opt_ty_46: [missing] -> pass (J0)
  • errors::verify_passes_should_be_applied_to_fn_10: pass -> [missing] (J0)
  • errors::verify_passes_should_be_applied_to_trait_11: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_fn_abi_105: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_generic_fn_104: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_item_106: pass -> [missing] (J0)
  • errors::verify_passes_unknown_external_lang_item_50: [missing] -> pass (J0)
  • errors::verify_passes_unnecessary_stable_feature_99: pass -> [missing] (J0)
  • errors::verify_passes_unrecognized_argument_71: pass -> [missing] (J0)
  • errors::verify_passes_unsupported_attributes_in_where_105: pass -> [missing] (J0)

(and 342 additional test diffs)

Additionally, 30 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ec6f62244c3a019e2224b779d2b606721cabf8f2 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6436.4s -> 8690.0s (+35.0%)
  2. dist-aarch64-apple: 7832.7s -> 6295.1s (-19.6%)
  3. dist-apple-various: 4413.9s -> 3637.8s (-17.6%)
  4. x86_64-gnu-llvm-21-3: 8451.9s -> 7179.9s (-15.0%)
  5. aarch64-apple: 11723.0s -> 10307.3s (-12.1%)
  6. dist-x86_64-apple: 7922.2s -> 8765.1s (+10.6%)
  7. dist-aarch64-llvm-mingw: 5774.4s -> 6310.4s (+9.3%)
  8. tidy: 163.5s -> 149.6s (-8.5%)
  9. aarch64-gnu-debug: 4669.7s -> 4281.3s (-8.3%)
  10. dist-powerpc64le-linux-gnu: 5282.1s -> 5711.7s (+8.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants