Skip to content

early return on duplicate span lowerings #149060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

early return on duplicate span lowerings #149060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions compiler/rustc_ast_lowering/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,13 @@ struct SpanLowerer {
impl SpanLowerer {
fn lower(&self, span: Span) -> Span {
if self.is_incremental {
// early return: span lowering takes some time since it accesses the query dependency graph
// to make sure we rerun the right code paths when spans change. When we've already lowered a span,
// or don't have to, bail out ASAP.
if span.is_dummy() || span.parent().is_some_and(|i| i == self.def_id) {
return span;
}

span.with_parent(Some(self.def_id))
} else {
// Do not make spans relative when not using incremental compilation.
Expand Down
Loading