Resolve Name Conflicts in Type Variables - #23358
Open
George-Ogden wants to merge 2 commits into
Open
George-Ogden wants to merge 2 commits into
George-Ogden wants to merge 2 commits into
Conversation
Not successfully done after rebase
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6870 (Implement missing members suggestion shadows type parameters)
Rebases #21118, which can now be closed
When generating default trait implementations, nothing was done about conflicting names.
This PR fixes the issue and tidies up the implementation slightly.
Most of the work was done by @Natural-selection1, but I can fix any reviewer comments.