Provide a gdb pretty printer for smol_str::SmolStr #21011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo fix on grammar documentation
I assumer that's why there were already parentheses around the `':' Type`?
Make type in Param optional
10: Allow type aliases in extern blocks r=jonas-schievink a=jonas-schievink This is for the unstable feature rust-lang/rust#43467, which rustc uses internally Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
11: Allow both const & async modifiers r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
12: Fix .gitignore r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
I don't really look at the results of the benchmarks anyway, so having them in the repo creates a false sense of benchmarkdness. If I get to implementing proper benchmarking, I'd probably stay away from criterion -- we need something much much simpler for this crate.
23: modernize r=matklad a=matklad Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
The Travis workflow was deleted in 1150aa9
Move towards upstream `macro_rules!` model
Merge `text-size` into rust-analyzer
Merge `ungrammar` into rust-analyzer
Merge `smol_str` into rust-analyzer
perf: Reduce memory usage of symbol index
internal: Move `SymbolsDatabase` over to new salsa style
Rename `downcast_[ref|mut]_unchecked` -> `downcast_unchecked_[ref|mut]`
perf: Only populate public items in dependency symbol index
…tmrx lib: Bump editions to 2024 and remove legacy files
Example
---
```rust
fn main() { unsafe {1}.$0 }
```
**Before this PR**
```rust
fn main() { const unsafe {{1}} }
```
**After this PR**
```rust
fn main() { const { unsafe {1} } }
```
Book>Contributing>Testing: Fix typos and distracting word choices
…x-with-modifier-block Fix .const missing block on with modifier block
Fix not parse never type in inherent impl
Add guard support for replace_if_let_with_match
support rename after adding loop label
rustbot
added
the
S-waiting-on-review
dfaure-kdab
force-pushed
the
wip/dfaure/smolstr_pretty_printer
branch
from
c743f1c to
3712013
Compare
Auto-loaded via the debugger_visualizer attribute. Tested on smolstr's unittest: $ RUSTFLAGS="-C debuginfo=2 -C opt-level=0" cargo test -p smol_str --no-run $ rust-gdb target/debug/deps/test-a806b111557a7133 (gdb) break test::conversions (gdb) run (gdb) next (gdb) print s (and other locations in that file, to test the three cases: Inline, Static and Heap)
dfaure-kdab
force-pushed
the
wip/dfaure/smolstr_pretty_printer
branch
from
3712013 to
c58810b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
37 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-loaded via the debugger_visualizer attribute. Tested on smolstr's unittest:
$ RUSTFLAGS="-C debuginfo=2 -C opt-level=0" cargo test -p smol_str --no-run $ rust-gdb target/debug/deps/test-a806b111557a7133 (gdb) break test::conversions
(gdb) run
(gdb) next
(gdb) print s
(and other locations in that file, to test the three cases: Inline, Static and Heap)