ci: enable target x86_64-unknown-redox - #5355
Conversation
|
I think the docker file may need |
|
|
No idea then, perhaps @jackpot51 knows. (On that note, maybe you'd like to add a second target maintainer for redox? Just so you're not the only one to get pinged) |
|
For I wonder if a similar approach would make sense for some of the libc targets as well. |
| RUN mv /root/.redoxer /.redoxer | ||
|
|
||
| ENV PATH=$PATH:/.redoxer/toolchain/bin:/rust/bin \ | ||
| ENV PATH=$PATH:/root/.redoxer/x86_64-unknown-redox/toolchain/bin \ |
There was a problem hiding this comment.
From the CI manual, it should be more reliable to do this
| ENV PATH=$PATH:/root/.redoxer/x86_64-unknown-redox/toolchain/bin \ | |
| RUN ln -sf /root/.redoxer ~/.redoxer | |
| ENV PATH=$PATH:$HOME/.redoxer/x86_64-unknown-redox/toolchain/bin \ |
I have no idea where EPERM could happen, I haven't fully tested run-docker.sh, at glance it looks like it should works (the requirement to get the toolchain to work is only glibc >= 2.41), but let me know if this suggestion still fail so I can test myself.
I'm the build maintainer for Redox OS, so feel free to ping me anywhere about CI for redox.
There was a problem hiding this comment.
Right, we at least get build errors now.
There was a problem hiding this comment.
Looks like a lot of work to do, can it be optional for now? I can also help in spare time.
There was a problem hiding this comment.
There’s no way to make the whole job optional, but you can add a test skip for anything that’s not trivial to fix (see the skip_* functions in the libc-test/build directory)
There was a problem hiding this comment.
I think I can send PR to that file separately
There was a problem hiding this comment.
Is there a way forward for this PR? I don't have the expertise to resolve build errors so I'm minded to close it.
There was a problem hiding this comment.
I can create another PR that start from this, but I don't have the time to do it yet. Feel free to close this one.
There was a problem hiding this comment.
Issue opened: #5520. Perhaps this PR can be merged with the progress so far.
There was a problem hiding this comment.
I'm happy to take this but please update the commit message, since this doesn't enable it anymore
4e8b217 to
c5565a1
Compare
c4a9a68 to
5e6f4f6
Compare
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
ah, bad rebase, sorry for the pings |
No description provided.