meta: Explicitly include items in packaged crate

[bushrat011899]

Description

Exclude /etc folder from cargo package by explicitly listing items to include. Currently published version of libc includes /etc/libc-util.py which cargo-deny picks up as an executable. Added in 27a38e3

Checklist

• Relevant tests in libc-test/semver have been updated N/A
• Commit messages permalink to headers for added or changed API N/A
• Placeholder or unstable values like *LAST or *MAX have the standard doc comment N/A
• Tested locally (cargo test -p libc-test --target mytarget);
  • Tested using cargo package and inspecting that the Python script is excluded.

@rustbot label +stable-nominated

[tgross35]

Does it maybe make sense to switch from exclude to include? I feel like this has surprised us in the past.

[tgross35]

I think that's the better path. Would you be able to change the exclude to include? And cover at least:

• src
• tests
• examples (doesn't exist now but could in the future. Not sure if it will reject it)
• build.rs
• CHANGELOG*
• LICENSE*
• README*

(if you could post a diff of cargo package --list, that would be helpful too. Otherwise I can get it)

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[bushrat011899]

Does it maybe make sense to switch from exclude to include? I feel like this has surprised us in the past.

Yeah I think that makes more sense. I would assume it's easier to notice (and yank) if a libc version is missing required files than if it inadvertently includes additional ones.

I think that's the better path. Would you be able to change the exclude to include? And cover at least:

* src
* tests
* examples (doesn't exist now but could in the future. Not sure if it will reject it)
* build.rs
* CHANGELOG*
* LICENSE*
* README*

(if you could post a diff of cargo package --list, that would be helpful too. Otherwise I can get it)

The non-existent examples folder isn't an issue it seems so no problems there. Comparing before and after this commit using diff I get:

2,6d1
< .editorconfig
< .git-blame-ignore-revs
< .gitignore
< .release-plz.toml
< .rustfmt.toml
8d2
< CONTRIBUTING.md
16,17d9
< etc/libc-util.py
< rust-bors.toml

I think all of those make sense to exclude, but happy to amend!

[bushrat011899]

@rustbot ready

[tgross35]

Looks great, thank you!

View changes since this review