RepoBuilder::branch(): return a Result, handle invalid values#1296
Open
DanielEScherzer wants to merge 2 commits into
Open
RepoBuilder::branch(): return a Result, handle invalid values#1296DanielEScherzer wants to merge 2 commits into
RepoBuilder::branch(): return a Result, handle invalid values#1296DanielEScherzer wants to merge 2 commits into
Conversation
The test is currently marked as `#[should_panic]` because the implementation panics when the branch given is invalid, a follow-up commit will switch to returning a `Result`.
When the provided branch name cannot be converted to a `CString`, return an `Err` variant rather than panicking.
Contributor
Author
|
@rustbot label +semver-breaking-change |
rustbot
added
the
semver-breaking-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the provided branch name cannot be converted to a
CString, return anErrvariant rather than panicking.