more ABIs are now allowed in variadic functions #630
Conversation
|
started a Zulip topic |
kirtchev-adacore
left a comment
kirtchev-adacore
left a comment
There was a problem hiding this comment.
Looks good, just the alphabetization.
src/types-and-traits.rst
Outdated
| :dp:`fls_o4uSLPo00KUg` | ||
| A :dt:`variadic ABI` is any of the following :t:`[ABI]s`: | ||
|
|
||
| * :dp:`fls_OR85NVifPwjr` |
There was a problem hiding this comment.
Could you alphabetize the entries in this list?
This avoids defining a new term, and instead follows Rust Reference
|
it felt better to define variadic function instead of creating a new term, variadic ABI (275e8a1)... what you think @kirtchev-adacore (cc @traviscross) |
src/functions.rst
Outdated
| A :t:`variadic function` can only be used with one of the following :t:`[ABI]s`: | ||
|
|
||
| * :dp:`fls_OR85NVifPwjr` | ||
| ``extern "C"`` | ||
| * :dp:`fls_4s2IdfYDzPrX` | ||
| ``extern "C-unwind"`` | ||
| * :dp:`fls_ZJJppPfiJRou` | ||
| ``extern "aapcs"`` | ||
| * :dp:`fls_jOyZh9ujWWHQ` | ||
| ``extern "aapcs-unwind"`` | ||
| * :dp:`fls_Xdr0bFwxhWiB` | ||
| ``extern "cdecl"`` | ||
| * :dp:`fls_DpTFEHZAABdD` | ||
| ``extern "cdecl-unwind"`` | ||
| * :dp:`fls_b7FTlWfnX2OI` | ||
| ``extern "efiapi"`` | ||
| * :dp:`fls_eHPWHrvs7ETl` | ||
| ``extern "sysv64"`` | ||
| * :dp:`fls_mjCrvmikm58M` | ||
| ``extern "sysv64-unwind"`` | ||
| * :dp:`fls_4EUb9zFatZ97` | ||
| ``extern "win64"`` | ||
| * :dp:`fls_4B4B5FIqAes9` | ||
| ``extern "win64-unwind"`` |
There was a problem hiding this comment.
extern "system" / extern "system-unwind"?
traviscross
left a comment
traviscross
left a comment
There was a problem hiding this comment.
Other than the question about extern "system", this looks good to me.
|
Would like to, in future, use AbiKind, which is defined as the |
I like it! I left a minor suggestion for Tshepang. |
from review
> Since it is the job of the programmer to ensure proper ABI use, the rule must be stated as a requirement ("shall", "must", etc).
Co-authored-by: Hristian Kirtchev <60669983+kirtchev-adacore@users.noreply.github.com>
Co-authored-by: Hristian Kirtchev <60669983+kirtchev-adacore@users.noreply.github.com>
3 participants
Closes #624