-
Notifications
You must be signed in to change notification settings - Fork 315
[DRAFT] v0 mangling on nightly #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
leaving comments would have been easier if you used semantic line breaks instead of hard wrapping at a column count :) |
0836ea0 to
0cab632
Compare
| If that happens, you can use the legacy mangling scheme with | ||
| the `-Csymbol-mangling-version=legacy -Zunstable-options` flag. | ||
| Using the legacy mangling scheme requires nightly, it is not intended | ||
| to be stabilised so that support can eventually be removed. Either by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should stabilize it with the intent to deprecate and remove (/make it a no-op) it eventually just to ease the transition for people when it hits stable.
imo making it a no-op after stabilizing is not any more breaking than changing the default in the first place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to doing this but haven't included it in the blog post or patch yet, will ask in the MCP thread and see what others in the team think
teor2345
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the usage instructions could be a bit clearer
0cab632 to
ee8ae66
Compare
Blog post for rust-lang/compiler-team#938 once that MCP completes
Rendered