Skip to content

Manual weekly update to cargo-rbmt (to 0.4.0)#993

Open
satsfy wants to merge 2 commits into
rust-bitcoin:masterfrom
satsfy:fix-6398
Open

Manual weekly update to cargo-rbmt (to 0.4.0)#993
satsfy wants to merge 2 commits into
rust-bitcoin:masterfrom
satsfy:fix-6398

Conversation

@satsfy

@satsfy satsfy commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Supersedes #990

cargo-rbmt 0.4.0 dropped the bench subcommand in favor of the generic run passthrough, so cargo rbmt bench no longer exists and the Bench job fails to run. So I replaced it with the equivalent invocation recommended for benchmarks in the README.

Update RBMT Bot and others added 2 commits June 20, 2026 04:40
cargo-rbmt 0.4.0 dropped the `bench` subcommand in favor of the generic
`run` passthrough, so `cargo rbmt bench` no longer exists and the Bench
job fails to run.

Replace it with the equivalent invocation. `RUSTFLAGS="--cfg=bench"` enables
the benchmarks module gated behind `#[cfg(bench)]`. nightly is required because
`#[bench]` and test::Bencher belong to it.

@trevarj trevarj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8e6c659

@apoelstra apoelstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8e6c659; successfully ran local tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants