fix: include function pointer arguments in call_edges for reduce_to #898
+32
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call_edges method now collects both: 1. Direct calls: functions used as the func operand in Call terminators 2. Indirect calls: functions passed as arguments (ZeroSized constants) that may be called via function pointers This fixes the 'unknown function' issue when a function is passed as an argument to higher-order functions like Result::map.
jberthold
approved these changes
Dec 16, 2025
Member
|
👍 Good catch finding this! Maybe #897 should include this? |
jberthold
pushed a commit
to runtimeverification/solana-token
that referenced
this pull request
Dec 17, 2025
- Python tool updates runtimeverification/mir-semantics#893 , runtimeverification/mir-semantics#892 - Function pointer support runtimeverification/mir-semantics#894 - Stable-MIR-JSON update runtimeverification/mir-semantics#896, runtimeverification/mir-semantics#898 - [update spl/p-token.md to use #execTerminatorCall](runtimeverification/mir-semantics@39ce2a6) - Add --fail-fast and --maintainence-rate pyk flags (Add --fail-fast and --maintainence-rate pyk flags #900)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call_edges method now collects both:
This fixes the 'unknown function' issue when a function is passed as an argument to higher-order functions like Result::map.