refactor(rt): use frame ids in stack references#1056
Closed
refactor(rt): use frame ids in stack references#1056
Conversation
Contributor
Author
|
We don't need this because we can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft refactors stack-based
Reference/PtrLocalvalues to use stable frame ids instead of relative stack offsets.What changed
StackFrameframe ids as stable runtime identitiesValidation
make builduv --directory kmir run pytest src/tests/unit -quv --directory kmir run pytest src/tests/integration/test_decode_value.py -quv --directory kmir run pytest src/tests/integration/test_integration.py -q -x -k 'Ref-weirdRefs'uv --directory kmir run pytest src/tests/integration/test_integration.py -q -x -k 'main-a-b-c or closure-call'uv --directory kmir run pytest src/tests/integration/test_integration.py -q -x -k 'Ref-refAsArg or Ref-refReturned or Ref-doubleRef or iterator-simple'uv --directory kmir run pytest src/tests/integration/test_run_smir_random.py -quv --directory kmir run pytest src/tests/integration/test_cli.py -q -k 'show_to_module or show_statistics_and_leaves or show_printers_snapshot'Follow-up
PR #1003 can now be based on this draft and keep its pointer-cast/address-allocation work separate from the stack-reference-model refactor.