Clean up the trace format#122
Open
bbyalcinkaya wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the review feedback that the record "kind" had to be inferred from each record's shape.
kindfield to every trace record."instr"for per-instruction traces, or the operation name (hostCall,contractData,addObject,callContract,endWasm) for Soroban VM operations, so consumers can dispatch without inspecting shape.instrarray from Soroban VM operations (it just repeatedkind) and gave its operands proper names instead of positional array slots:hostCallnow hasmodule/function,contractDatanow hasoperation/durability.posfrom Soroban VM operations, since it was alwaysnullthere; kept only on instruction records, where it's a real byte offset.docs/tracing.mdto document the new format, with a runnablekomet run+jqexamples section.