Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #721
Problem
rp flash deploypasses eachrequirements.txtline to the vendoring step unchanged unless the line starts with#, so a line such asrequests==2.32.3 # http clientis rejected as an invalid requirement.Fix
_requirements_txtremoves a comment before it keeps the line, using pip's rule: a#at the start of a line or after whitespace begins a comment. A#inside a URL, such as#sha256=..., is kept. This change does not touch-rhandling.Tests
One test in
tests/test_apps/test_build.py, failing without this change: a line with an inline comment, a line with a tab before the comment, and a URL requirement with a#sha256=fragment that must be kept.Before and after
requirements.txtcontainingrequests==2.32.3 # http client,rp flash deploy --build-only:Error: dependency vendoring failed: ERROR: Invalid requirement: 'requests==2.32.3 # http client'requests-2.32.3is in the artifact