Repository navigation
feat(sandbox): add options lookup for enabled datacenters and CPU flavors - #704
Draft
zackmckennarunpod wants to merge 3 commits into
Draft
zackmckennarunpod wants to merge 3 commits into
zackmckennarunpod wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
Sandbox.options()andAsyncioSandbox.options(), which return the data centers, CPU flavors and account limits for a sandbox create, read fromGET /v2/sandboxes/options.This is based on #595 (sync and async sandbox SDK), because that is where the sandbox client lives. Retarget it to
mainonce #595 merges.The REST route comes from
runpod/rphttp2and is still in draft there, so a live call returns 404 until that deploys.Verification
pytest tests/test_sandbox.py tests/test_sandbox_contract.pypasses against the local fake server, including the three new tests, which failed before the change.