update bank-tab-names#13313
Merged
Merged
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates bank-tab-names.
Issue 1: Configs from the original plugin were lost on update
The rewrite moved to a new config group and never read the old "BankTabNames" group, so anyone updating from the pre-rewrite plugin lost their tab names. This has been my most common support issue by far.
Fixed with a one-time import that runs on startup, gated by a config version stamp. If the user has nothing set up in the new version, their old setup is restored live. If they have configs in both, both are kept as loadable presets in the panel and nothing gets overwritten. The old keys are never deleted, so the import can't destroy anything. A single chat message on next login tells the user where their config went.
Files: BankTabNamesPlugin.java (migration + login notice), BankTabNamesPanel.java (shared preset key constant).
Issue 2: Clicking near the edge of a bank tab could shuffle tab designs
A slipped click onto a neighboring tab was enough to swap the name layouts even when the game itself never reordered the tabs.
Fixed by requiring a short hold and a minimum cursor movement before a swap registers. Both thresholds are adjustable in a new "Drag protection" config section, and either can be set to 0 to disable the guard.
Files: BankTabNamesPlugin.java (threshold checks), BankTabNamesConfig.java (new config section).