Ngrok Support#21
Open
davidaarmstrong wants to merge 15 commits into
Open
Conversation
Removed call to the now defunct `markdown::markdownExtensions()` function (formerly line 336).
Owner
|
I made some small fixes and a couple of changes (as recommended by claude) - could you test and let me know if I broke anything or not. |
…s from Positron and other IDEs now
Merge existing work
Author
|
Your changes were seemed to work. I also made a few other changes to solve the problems mentioned in one of the other issues that the functions depend on being called from within RStudio. It should work in other IDEs now. |
- Wrap websocket_loop body in tryCatch so rstudioapi errors (e.g. stale file_id) no longer kill the update loop permanently - Move later::later(websocket_loop, interval) outside the tryCatch so the loop always reschedules, even after an error - Defer the first websocket_loop kick-off via later::later instead of calling it synchronously inside onWSOpen, avoiding rstudioapi calls from within the WebSocket handler - Guard against sending empty file content (race between documentSave truncating and writing the file) in both the loop and initial send - Add WebSocket reconnection logic in livecode.js with exponential back-off (1s → 30s cap) so clients survive transient disconnects Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main update here is adding support to direct tunneling through
ngrok. Theserve_file()function, now takes argumentstunnel(logical) indicating whether a tunnel to ngrok should be created andngrok_domain, which allows you to use a custom domain if you have a paid account onngrok.