Conversation
The class_variable_defined? guard in the reader and writer already keeps the default block from running twice, so cattr and mattr can pass the block straight through instead of splitting writers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2Njj4j1r9twkVcXsMySLW
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow-up promised in #317.
Summary
cattrandmattrsplit the writers intowriters - readersandwriters & readersso the default block wouldn't run a second time for an attribute that already has a reader. That split isn't needed.*_readerand*_writeronly set the default whenclass_variable_defined?is false, so once the reader has set it, the writer skips the block anyway.Both methods now just pass
&blockthrough:The change is in
lib/core/facets/module/mattr.rb: 2 lines added, 13 removed.Testing
I checked
cattrandmattrwith a Ruby 3.3 script. The #317 behavior is unchanged:cattr(:y, :y=) { … }/mattr(:y, :y=) { … }the block runs exactly once.I didn't run the repo's
ruby-testsuite locally; CI runs it.🤖 Generated with Claude Code
https://claude.ai/code/session_01E2Njj4j1r9twkVcXsMySLW
Generated by Claude Code