chore(build)!: align toolchains and harden dependency updates - #281
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Three moderate findings and one nit remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Aligns local and CI Erlang/Elixir toolchains and strengthens dependency-update validation.
Changes:
- Updates toolchain pins across
mise.tomland GitHub workflows. - Adds workflow pin validation to CI.
- Fetches dependencies during setup and runs full CI after updates.
| File | Summary |
|---|---|
workflow.opus.yaml |
Fetches dependencies after setup. moderate (1 vote): ensure failed mix setup cannot be masked. |
test/mix/tasks/toolchain.check_test.exs |
Tests pin validation. moderate (1 vote): add fixtures covering the real YAML list-item structure. |
test/mix/tasks/appdeps.update_test.exs |
Tests the post-update CI gate. |
mise.toml |
Updates pins and adds tasks. nit (2 votes): reconcile the toolchain pins with the referenced phase-8 decision. |
lib/mix/tasks/toolchain.check.ex |
Implements workflow pin validation. moderate (1 vote): parse each inline setup-beam step independently. |
lib/mix/tasks/ci.ex |
Runs toolchain validation in CI. |
lib/mix/tasks/appdeps.update.ex |
Runs the full CI gate after dependency updates. |
.github/workflows/usage-rules-sync.yaml |
Updates workflow toolchain pins. |
.github/workflows/main.yaml |
Updates release/build toolchain pins. |
.github/workflows/ci.yaml |
Updates CI toolchain pins. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.