ci(hooks): stop rerunning precommit before push - #279
Merged
Merged
Conversation
bougyman
commented
Sep 21, 2026
bougyman
commented
Member
- fix(test): eliminate async stderr capture race
- chore: updates vulnerable dependencies
- ci(hooks): stop rerunning precommit before push
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The pre-push regression test does not fully verify that mix precommit is not invoked.
Review effort: Lite
Findings: None
What changed in this PR
This PR stops redundant pre-push checks, isolates async stderr capture, updates dependencies, and revises related documentation.
Changes:
- Removes the duplicate
mix precommitinvocation. - Adds injectable stderr handling for async tests.
- Updates dependencies and quality-gate guidance.
Review note: strengthen the pre-push regression test with a fake mix command and marker assertion.
| File | Summary |
|---|---|
test/git_hooks_test.exs |
Updates pre-push coverage. |
lib/mix/tasks/precommit.ex |
Updates task documentation. |
lib/mix/tasks/git_hooks.ex |
Updates hook documentation. |
git-hooks/pre-push |
Removes redundant precommit execution. |
documents/quality-gates-decision.adoc |
Documents revised gate responsibilities. |
app/usage-rules.md |
Updates local hook guidance. |
app/test/support/issue_commands_helpers.ex |
Adds isolated stderr capture. |
app/test/linear_cli/cli/commands/issues/relations_test.exs |
Migrates async stderr assertions. |
app/test/linear_cli/cli/commands/issues/mutations_test.exs |
Migrates async stderr assertions. |
app/test/linear_cli/cli/commands/issues/move_test.exs |
Migrates async stderr assertions. |
app/test/linear_cli/cli/commands/issues/graph_test.exs |
Migrates async stderr assertions. |
app/test/linear_cli/cli/commands/issues/create_test.exs |
Migrates async stderr assertions. |
app/mix.lock |
Updates dependency versions. |
app/lib/linear_cli/cli/commands/issues/relations.ex |
Routes relation errors to injected stderr. |
app/lib/linear_cli/cli.ex |
Supports configurable stderr handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.