Skip to content

Fix uninitialized constant CustomDeviseMailer on new org user invite (Resolves #5745) #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apostergiakis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix uninitialized constant CustomDeviseMailer on new org user invite (Resolves #5745) #5762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ GEM
railties (>= 7.0)
responders
warden (~> 1.2.3)
devise_invitable (2.0.13)
devise_invitable (2.0.14)
actionmailer (>= 5.0)
devise (>= 4.6)
diff-lcs (1.6.2)
Expand Down
16 changes: 16 additions & 0 deletions spec/lib/custom_devise_mailer_load_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
require "open3"

# Autoloading CustomDeviseMailer in a fresh process used to raise
# "uninitialized constant CustomDeviseMailer" (#5745): devise_invitable 2.0.13's
# :action_mailer load hook resolved Devise.mailer while the class was still loading
# (fixed in 2.0.14, scambra/devise_invitable#929).
# CI eager-loads, which hides it, so this boots a separate non-eager-loaded process.
RSpec.describe "CustomDeviseMailer cold load" do
it "resolves Devise.mailer when autoloaded first in a fresh process" do
env = {"RAILS_ENV" => "test", "CI" => nil}
output, status = Open3.capture2e(env, "bin/rails", "runner", "puts Devise.mailer.name", chdir: Rails.root.to_s)

expect(status).to be_success, output
expect(output.lines.map(&:strip)).to include("CustomDeviseMailer")
end
end