Skip to content

Use auto-submit Stimulus for case contacts filters (#7309) #7356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KoushikSagarr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use auto-submit Stimulus for case contacts filters (#7309) #7356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions app/javascript/__tests__/case_contact.test.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion app/javascript/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ Turbo.session.drive = false
require('datatables.net-dt')(null, window.jQuery) // First parameter is the global object. Defaults to window if null
require('@rails/ujs').start()
require('@rails/activestorage').start()
require('./src/case_contact')
require('./src/case_emancipation')
require('./src/casa_case')
require('./src/new_casa_case')
Expand Down
15 changes: 0 additions & 15 deletions app/javascript/src/case_contact.js
View file
Open in desktop

This file was deleted.

18 changes: 9 additions & 9 deletions app/views/case_contacts/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
</div>
</div>

<%= form_for_filterrific @filterrific, url: case_contacts_path, html: {class: "filter-form mb-6"}, remote: true,
data: {turbo: true, turbo_frame: :case_contacts, turbo_action: :advance} do |f| %>
<%= form_for_filterrific @filterrific, url: case_contacts_path, html: {class: "filter-form mb-6"},
data: {controller: "auto-submit"} do |f| %>
<%= hidden_field_tag "casa_case_id", params[:casa_case_id] %>

<% panel_open = filters_open? %>
Expand All @@ -54,7 +54,7 @@
Not "Filter by" -- it changes the order, not which rows show. %>
<%= f.label :sorted_by, "Sort by", class: label_class %>
<div class="relative">
<%= f.select(:sorted_by, @filterrific.select_options[:sorted_by], {}, {class: select_class}) %>
<%= f.select(:sorted_by, @filterrific.select_options[:sorted_by], {}, {class: select_class, data: {action: "change->auto-submit#submit"}}) %>
<i class="<%= chevron %>" aria-hidden="true"></i>
</div>
</div>
Expand All @@ -64,7 +64,7 @@
group wraps on narrow screens. %>
<div class="flex min-h-[38px] flex-wrap items-center gap-x-4 gap-y-2">
<label class="inline-flex items-center gap-2 text-sm text-slate-700">
<%= f.check_box :no_drafts, class: check_class %>
<%= f.check_box :no_drafts, class: check_class, data: {action: "change->auto-submit#submit"} %>
Hide drafts
</label>
<%# clear_filters_path, not reset_filterrific_url: reset drops the SORT too, and a control
Expand Down Expand Up @@ -92,11 +92,11 @@
<div class="grid grid-cols-1 gap-4 sm:grid-cols-2">
<div>
<%= f.label "Starting from", for: "filterrific_occurred_starting_at", class: label_class %>
<%= f.date_field(:occurred_starting_at, class: input_class) %>
<%= f.date_field(:occurred_starting_at, class: input_class, data: {action: "change->auto-submit#submit"}) %>
</div>
<div>
<%= f.label "Ending at", for: "filterrific_occurred_ending_at", class: label_class %>
<%= f.date_field(:occurred_ending_at, class: input_class) %>
<%= f.date_field(:occurred_ending_at, class: input_class, data: {action: "change->auto-submit#submit"}) %>
</div>
</div>
</div>
Expand Down Expand Up @@ -130,21 +130,21 @@
<div class="relative">
<%# Pass the current value: pre-rendered option HTML can't be marked selected by f.select,
so without it the dropdown reads "All" while a medium filter is active. %>
<%= f.select(:contact_medium, options_from_collection_for_select(contact_mediums, "value", "label", f.object.contact_medium), {include_blank: "All"}, {class: select_class}) %>
<%= f.select(:contact_medium, options_from_collection_for_select(contact_mediums, "value", "label", f.object.contact_medium), {include_blank: "All"}, {class: select_class, data: {action: "change->auto-submit#submit"}}) %>
<i class="<%= chevron %>" aria-hidden="true"></i>
</div>
</div>
<div>
<%= f.label :want_driving_reimbursement, class: label_class %>
<div class="relative">
<%= f.select(:want_driving_reimbursement, @case_contacts.boolean_select_options, {include_blank: "All"}, {class: select_class}) %>
<%= f.select(:want_driving_reimbursement, @case_contacts.boolean_select_options, {include_blank: "All"}, {class: select_class, data: {action: "change->auto-submit#submit"}}) %>
<i class="<%= chevron %>" aria-hidden="true"></i>
</div>
</div>
<div>
<%= f.label :contact_made, class: label_class %>
<div class="relative">
<%= f.select(:contact_made, @case_contacts.boolean_select_options, {include_blank: "All"}, {class: select_class}) %>
<%= f.select(:contact_made, @case_contacts.boolean_select_options, {include_blank: "All"}, {class: select_class, data: {action: "change->auto-submit#submit"}}) %>
<i class="<%= chevron %>" aria-hidden="true"></i>
</div>
</div>
Expand Down
Loading