Skip to content

Delete dead All-CASA-admin DataTables scripts (#7303) - #7354

Open
KoushikSagarr wants to merge 1 commit into
rubyforgood:mainfrom
KoushikSagarr:7303-remove-all-casa-datatables
Open

KoushikSagarr wants to merge 1 commit into
rubyforgood:mainfrom
KoushikSagarr:7303-remove-all-casa-datatables

Conversation

@KoushikSagarr

@KoushikSagarr KoushikSagarr commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

What github issue is this PR for, if any?

Resolves [#7303]

What changed, and why?

  • Deleted the obsolete app/javascript/src/all_casa_admin/tables.js DataTables initialization.
  • Deleted the now-unused shared app/javascript/datatable.js helper.
  • Removed the obsolete require('./src/all_casa_admin/tables') entry from app/javascript/all_casa_admin.js.
  • Removed the unused import './datatable.js' entry from app/javascript/application.js.
  • Confirmed that the legacy table.admin-list and table.organization-list selectors are no longer referenced by application views, templates, or helpers.
  • Kept changes strictly limited to the obsolete All-CASA-admin DataTables scripts and their application entry points. The datatables.net-dt dependency remains untouched as requested.

This is another small, independently reviewable contribution toward removing obsolete JavaScript code from CASA.

How is this tested? (please write rspec and jest tests!) 💖💪

  • Jest: 15 test suites passed, 124 tests passed, 0 failures.
  • Asset build: npm run build && npm run build:css completed successfully with 0 errors and 0 warnings.
  • RSpec: spec/system/all_casa_admins — 19 examples, 0 failures.
  • Reference verification: Confirmed that initializeDataTable, table.admin-list, and table.organization-list have no remaining application references.
  • Dependency verification: Confirmed datatables.net-dt remains unchanged in package.json, package-lock.json, and app/javascript/application.js.
  • Git diff: git diff --check passed with no whitespace errors.

Screenshots please :)

Not applicable — this PR removes obsolete JavaScript initialization without introducing UI changes.

Feelings gif (optional)

Another cleanup PR in the books. Less legacy JavaScript, cleaner CASA! 💪

@github-actions github-actions Bot added the javascript Touches JavaScript code label Nov 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Touches JavaScript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant