Add coverage for Followups and Mileages reports#6856
Open
stefannibrasil wants to merge 1 commit intorubyforgood:mainfrom
Open
Add coverage for Followups and Mileages reports#6856stefannibrasil wants to merge 1 commit intorubyforgood:mainfrom
stefannibrasil wants to merge 1 commit intorubyforgood:mainfrom
Conversation
Followup report handle CSV exports with authorization and the Mileage report handles Reimbursement CSV exports. Both have placeholder specs only. Let's add coverage to ensure they work as expected and no bugs are introduced. The services that generate the report data have extensive coverage already, so keep this unit test focused on the request, I only tested for the format and the headers.
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Close #6842
What changed, and why?
Followup report handle CSV exports with authorization and the Mileage report handles
Reimbursement CSV exports. Both have placeholder specs only.
Let's add coverage to ensure they work as expected and no bugs are introduced.
The services that generate the report data have extensive coverage already, so keep this unit test focused on the request, I only tested for the format and the headers.