Add request specs for mileage and followup reports controllers#6855
Closed
costajohnt wants to merge 1 commit intorubyforgood:mainfrom
Closed
Add request specs for mileage and followup reports controllers#6855costajohnt wants to merge 1 commit intorubyforgood:mainfrom
costajohnt wants to merge 1 commit intorubyforgood:mainfrom
Conversation
Replace placeholder controller specs with proper request specs for MileageReportsController and FollowupReportsController. Both controllers serve CSV downloads and authorize via see_reports_page? which permits supervisors and admins. Tests cover: - Successful CSV download for casa_admin and supervisor - Authorization denial for volunteer (redirect to root) - Unauthenticated access (redirect to sign in) - CSV content verification with actual data Addresses rubyforgood#6833
costajohnt
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
Contributor
|
Hi @costajohnt sorry for the confusion, but I was already assigned to working on these in #6842 and I am working on them. I would recommend seeing if there are open issues/PRS already for each file to prevent duplicated work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MileageReportsControllerandFollowupReportsControllersee_reports_page?case_contact_reports_spec.rbTest plan
Addresses #6833