JM: Capture sector "Other" free-text as records; curate (promote/keep/dismiss)#1939
JM: Capture sector "Other" free-text as records; curate (promote/keep/dismiss)#1939maebeale wants to merge 3 commits into
Conversation
| # they can be curated (promoted/kept/dismissed). Reuses OtherOption.texts, the | ||
| # same extraction used to display them, and de-dupes on the person's normalized | ||
| # value so a repeat registration of the same text doesn't create a second row. | ||
| def capture_other_sector_responses(submission) |
There was a problem hiding this comment.
🤖 From Claude: Capture reuses OtherOption.texts (the same extraction the display used) and find_or_create_by on the person + normalized value, so a repeat registration of the same "Other" text doesn't create a second row or trip the unique index.
| sector = target_sector | ||
| return redirect_to other_responses_path, alert: "Pick or name a sector to promote to." unless sector | ||
|
|
||
| responses = OtherResponse.sectors.promotable_now |
There was a problem hiding this comment.
🤖 From Claude: promotable_now excludes dismissed — so "dismissed wins": promoting a value never re-tags someone who deliberately hid it.
| <%= response.text %> | ||
| <span class="ml-1 text-xs text-gray-400">(other)</span> | ||
| <% if dismissable %> | ||
| <%= link_to "×", |
There was a problem hiding this comment.
🤖 From Claude: Dismiss is a link_to with turbo_method: :patch, not button_to — this chip lives inside the person edit <form>, and a nested <form> (what button_to emits) is invalid HTML.
Free-text "Other" sector values were derived on the fly from form answers and shown as read-only chips with nowhere to hang a curation decision. Materialize them as records so a curator can promote a recurring value into a real Sector, keep it as a free-text chip, or dismiss it (hide from profile/edit). Data layer only: migration, model, factory, specs. `kind` leaves room for the identical workshop-setting responses to migrate here later. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Capture free-text "Other" sector answers as OtherResponse records at registration time (PublicRegistration), de-duped per person. - Person#other_sector_responses now reads the visible (pending/kept) records; profile + edit render them via a records-based partial. The edit chip gains an × that dismisses (hides) a response. Submission view is untouched (audit). - Admin review page (/other_responses) groups the same value across people with a count; promote maps them all to an existing sector or mints a new published one and tags every non-dismissed person. Reachable from the Sectors index. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The review page could only promote; add Keep all / Dismiss all bulk actions per grouped value, and a status filter (All / Pending / Kept) so kept responses stay visible in the queue but can be filtered out. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/hide-sector-other-from-profile
branch
from
f22fbe8 to
1b3fb0f
Compare
|
|
||
| # Bulk keep/dismiss every visible person who typed this value, from the review | ||
| # queue. Keep leaves it as a free-text chip; dismiss hides it from profiles. | ||
| def curate |
There was a problem hiding this comment.
🤖 From Claude: Bulk keep/dismiss acts on the whole grouped value (all VISIBLE_STATUSES rows for this normalized_text), mirroring how promote fans out across everyone who typed it. return_status round-trips the active filter so the queue stays put after the action.
maebeale
changed the title
|
what we have now on profile w form submission data is super brittle. this would allow us to capture all form 'other' answer data and decide if it gets promoted, wiped, or kept as auxiliary data. |
🤖 suggested review level: 5 Inspect 🔬 new model + registration capture path + profile/edit display swaps + admin review page whose promote/keep/dismiss actions transform tags across many people
Why
Free-text "Other" sectors people type on registration forms were derived on the fly from form answers and shown as read-only chips — with nowhere to record a curation decision, and no way to hide one that shouldn't appear on the public profile.
What
OtherResponsemodel materializes each person's typed "Other" (kind: "sector"now; column leaves room for workshop settings later). Statuses:pending→promoted/kept/dismissed.PublicRegistration), de-duped per person. No backfill — there are no existing public registrations./other_responses, linked from the Sectors index): groups the same value across people with a count, filterable by All / Pending / Kept. Per group:Decisions baked in
Sector(not added to theSECTOR_TYPESseed constant — DB is source of truth).keptresponses stay visible in the review queue (filter to hide them) rather than dropping off.Tests
Model, registration capture (request), profile/edit rendering + dismiss, and the review page (index, filter, dismiss, bulk keep/dismiss, promote incl. new-sector minting).
Rebased on main
Resolved conflicts with #1872 (age-range editor restructured the person form/profile — took its layout, kept the renamed
other_sector_responsespartial) and confirmed coexistence with #1875 (orgagency_type_other, a separate concern).