HOLD: Replace org-index windows-type filter/column with age-range filter#1927
Draft
maebeale wants to merge 1 commit into
Draft
HOLD: Replace org-index windows-type filter/column with age-range filter#1927maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
maebeale
commented
Jun 29, 2026
| .where(categorizable_items: { category_id: category_ids }) | ||
| .select(:id) | ||
|
|
||
| where(id: org_tagged).or(where(id: via_affiliations)).or(where(windows_type_id: windows_type_ids)) |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Three-legged OR is the heart of the filter: org-own tag, affiliated-person tag (mirrors the column's aggregation), or windows-audience semantic coverage. All three are plain wheres on organizations with no joins, so .or stays structurally compatible.
maebeale
commented
Jun 29, 2026
| def windows_audience_unreflected_by_age_tags? | ||
| return false unless windows_type | ||
| tagged = all_primary_age_groups + all_additional_age_groups | ||
| return true if tagged.empty? |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Empty tags → true is intentional: an org with a windows audience but no age tags is exactly the case we want to surface the badge for. Otherwise we only show it when the audience covers a range the tags omit.
maebeale
commented
Jun 29, 2026
| :windows_type, :organization_status, :sectors, :addresses, | ||
| :organization_status, :sectors, :addresses, | ||
| { windows_type: { categorizable_items: { category: :category_type } } }, | ||
| { categorizable_items: { category: :category_type } }, |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Eager-loads the windows type's age-range categories so windows_audience_unreflected_by_age_tags? (which reads categorizable_items in Ruby) doesn't N+1 across the 25 rows per page.
The age-range category tags now carry audience info on the organizations index, so the separate windows-type column and "Windows audience" filter are redundant. Replace them with a single "Age range" filter over the AgeRange categories. Because some orgs have a windows audience but no age-range tags — or tags that disagree with it — matching ORs the org's (and affiliated people's) age-range tags with the windows audience's semantic age ranges, and the windows-type badge is surfaced in the age-range column whenever it adds age info the tags don't already convey. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/age-range-filter-windows-type
branch
from
2b443be to
073b692
Compare
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR, suggested 👤 review level: 📖 Read — light-logic: a new filter scope + a display fallback, contained to the organizations index
What & why
Age-range category tags now carry audience info on the organizations index, making the separate windows-type column and "Windows audience" filter redundant.
Notes
WindowsTypeFilterableis left intact — it's shared by many other models; only the org index stops usingwindows_type_name.Test plan
spec/models/organization_spec.rbcovers.age_range_names(org tag / affiliated-person tag / windows-audience fallback / exclusion) and#windows_audience_unreflected_by_age_tags?.