Org "Pending" badge: suppress once linked, surface on the link editor#1926
Merged
Conversation
The roster's "Pending" org chip now shows only while a registrant has no linked organization — once an admin links any org they've made the call, so a non-matching submitted name no longer reads as pending. For continuity, the link-organization editor now shows the same amber "Pending" badge next to the submitted org name while nothing is linked, so it's clear why the registrant was flagged when you open it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
commented
Jun 29, 2026
| <%# A submitted org name needs admin attention only while nothing is linked | ||
| yet; once an admin links any org they've made the call, so a non-matching | ||
| submitted name is no longer treated as pending. %> | ||
| <% needs_linking = submitted_org_name.present? && linked_orgs.none? %> |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: The chip now keys off linked_orgs.none? rather than name-matching: once an admin has linked any org they've resolved it, so a different submitted name is no longer noise.
maebeale
commented
Jun 29, 2026
| <% end %> | ||
| <div class="min-w-0"> | ||
| <p class="text-base text-gray-800">Organization: <strong><%= entry[:org_name].presence || "—" %></strong><% if entry[:organization]&.city_state.present? %> <span class="text-sm text-gray-500">· <%= entry[:organization].city_state %></span><% end %></p> | ||
| <p class="text-base text-gray-800">Organization: <strong><%= entry[:org_name].presence || "—" %></strong><% if entry[:organization]&.city_state.present? %> <span class="text-sm text-gray-500">· <%= entry[:organization].city_state %></span><% end %><%# Mirror the roster's amber "Pending" chip so it's clear why this registrant was flagged — shown only while nothing is linked. %><% if entry[:org_name].present? && @linked_organizations.none? %> <span class="ml-1 inline-flex items-center gap-1 rounded-full border border-amber-200 bg-amber-50 px-2.5 py-0.5 text-xs font-medium text-amber-700" title="The registrant submitted this organization, but none is linked to the registration yet."><i class="fa-solid fa-circle-exclamation text-[0.65rem]"></i>Pending</span><% end %></p> |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Same amber "Pending" badge as the roster, shown only while @linked_organizations.none?, so opening the editor explains why the registrant was flagged — and it disappears the moment something is linked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR, suggested 👤 review level: 👀 Skim — view-only: two ERB views + specs, no logic/data changes
What is the goal of this PR and why is this important?
How did you approach the change?
_registrants_results.html.erb):needs_linkingnow keys offlinked_orgs.none?instead of comparing the submitted name against linked names.link_organization.html.erb): amber "Pending" badge in the "Registration form submission" section, shown only when@linked_organizations.none?.Anything else to add?