Use "Submit" label on /new form buttons

[maebeale]

What is the goal of this PR and why is this important?

• Standardizes the submit call to action on new-record forms to read "Submit" instead of "Create <Model>"
• Gives creation screens a consistent label across the app

How did you approach the change?

• Replaced explicit "Create …" submit labels with "Submit" on forms served from /new endpoints
• For partials shared between new and edit, only the new-record branch was changed; the edit label (e.g. "Save changes" / "Update") is preserved
• Files touched:
  • forms/new.html.erb — "Create form" → "Submit"
  • payments/_form.html.erb (rendered only by payments/new) — "Create Payment" → "Submit"
  • allocations/new.html.erb — "Create Allocation" → "Submit"
  • refunds/new.html.erb — "Create Refund" → "Submit" (kept "Refund via Stripe" branch)
  • scholarships/_form.html.erb — new branch "Create scholarship" → "Submit"
  • event_registrations/_form.html.erb — new branch "Create registration" → "Submit"

Anything else to add?

• Marked HOLD pending confirmation on scope.
• Intentionally left unchanged (flagging for reviewer):
  • payments/_allocation_form.html.erb and discounts/_allocation_form.html.erb ("Create Payment"/"Create Discount") render via the custom allocation_form turbo action, not a /new route.
  • ~30 forms use bare f.button :submit (no explicit label); simple_form auto-renders these as "Create <Model>" on new / "Update <Model>" on edit. Switching those to "Submit" would require a per-form persisted? conditional in each shared partial — held off pending direction.

🤖 Generated with Claude Code

[maebeale]

🤖 From Claude: This partial is shared by new and edit, so only the non-persisted branch changes to "Submit" — the edit label ("Save changes") is intentionally preserved.

[Copilot]

Pull request overview

This PR standardizes the primary submit button label on /new (create) forms to “Submit”, improving consistency across the Rails app’s new-record creation screens while preserving edit-specific labels in shared partials.

Changes:

• Updated new-record submit labels to “Submit” in several /new views and the “new” branches of shared form partials.
• Preserved existing edit/update button labels (e.g., “Save changes”) where the partial is shared by both new and edit.
• Kept the special-case refund CTA (“Refund via Stripe”) unchanged.

Outstanding decisions:

• Confirm whether the intended scope should remain limited to explicitly-labeled /new forms, or if the broader set of forms relying on Simple Form’s default “Create ” label should also be updated.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
app/views/scholarships/_form.html.erb	Changes the new-record submit label to “Submit” while keeping “Save changes” for persisted records.
app/views/refunds/new.html.erb	Updates the non-Stripe refund submit label to “Submit” while preserving the “Refund via Stripe” branch.
app/views/payments/_form.html.erb	Updates the submit label to “Submit” in the partial used by the new payment flow.
app/views/forms/new.html.erb	Changes the new form creation submit label from “Create form” to “Submit”.
app/views/event_registrations/_form.html.erb	Changes the new-record submit label to “Submit” while keeping “Save changes” for persisted records.
app/views/allocations/new.html.erb	Updates the allocation creation submit label to “Submit”.