Remove Credit Card option from payment and allocation filters#1859
Merged
Conversation
The CreditCardPayment type is no longer used; drop it from the payments Type filter and allocations Source type filter so the dropdowns only offer payment types that actually exist. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy “Credit Card” (CreditCardPayment) option from admin-facing filter dropdowns so users can’t select a payment type that no longer yields results.
Changes:
- Removed “Credit Card” from the Payments Type filter options.
- Removed “Credit Card” from the Allocations Source type filter options.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/views/payments/_search_boxes.html.erb | Removes CreditCardPayment from the payments type filter dropdown. |
| app/views/allocations/_search_boxes.html.erb | Removes CreditCardPayment from the allocations source-type filter dropdown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CreditCardPaymentpayment type is no longer used, but it still appears as a "Credit Card" option in two filter dropdowns. Selecting it can only ever return zero results.What
app/views/payments/_search_boxes.html.erb).app/views/allocations/_search_boxes.html.erb).Notes
HOLD:— opening as a placeholder; confirmCreditCardPaymentis truly retired (no historical records still typed asCreditCardPaymentthat admins need to filter for) before merging.Events::PublicRegistrationsController#credit_card_payment?untouched — that's the event-registration "payment method" form field that routes to Stripe checkout, unrelated to theCreditCardPaymentpolymorphic type.🤖 Generated with Claude Code