Gate remote_select style injection on an id to prevent <style> leak#1858
Merged
Conversation
The connect() lifecycle appended an identical <style> tag on every connect (Turbo nav, cocoon add, reconnect), leaking duplicates into document.head. Gate the injection on an element id so the shared global stylesheet is appended once and reused, satisfying Stimulus lifecycle discipline. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
remote_select_controller.jsleaked a<style>tag on every Stimulusconnect()connect()randocument.head.appendChild(style)unconditionally — no "append once" guard and nodisconnect()cleanup<style>into<head>, violating the lifecycle rule that anything created inconnect()must be cleaned upHow did you approach the change?
injectStyles()method gated on an element id (remote-select-styles)disconnect()removal because the stylesheet is global, not per-instance: multipleremote_selectcontrollers can be live at once, so removing the tag on any one disconnect would break the others. The existingdisconnect()still destroys the per-instance TomSelect.Anything else to add?