WAIT: Add toggle UX for workshop selection on story ideas#1853
Draft
maebeale wants to merge 7 commits into
Draft
WAIT: Add toggle UX for workshop selection on story ideas#1853maebeale wants to merge 7 commits into
maebeale wants to merge 7 commits into
Conversation
Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
Resolve trailing whitespace from merge, remove duplicate closing tags in form view, and update tests to use build instead of create where workshop validation now prevents nil workshop + nil external title. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Users need an intuitive way to enter custom workshop titles when submitting story ideas. Previously, both dropdown and text field were always visible, causing confusion about which to use.
How did you approach the change?
Frontend: Stimulus controller manages toggle between dropdown and text input
Backend: Controller prepends virtual "New Workshop" option, converts
workshop_id: "new"tonilValidation: Custom validator ensures either
workshop_idorexternal_workshop_titlepresentCode organization: Extracted view conditionals to helpers (
workshop_selected_value,show_external_workshop_field?)Anything else to add?
Model tests confirm validation logic. Request spec verifies "new" value handling. CodeQL scan clean.
Warning
WAIT — do not merge yet. Rebased onto latest
main. During the rebase a conflict surfaced:mainhas since migrated the story-idea workshop selector to a dynamicremote-select(TomSelect remote search) field, while this PR is built on the older static@workshopsdropdown. The rebase resolution kept this PR's static-dropdown + toggle approach and droppedmain'sremote-selectfor that field. This needs a product/architecture decision before merge — see the PR conversation for the recap.