Skip to content

WAIT: Save logged_out_only answers for signed-in registrants#1840

Draft
maebeale wants to merge 1 commit into
mainfrom
maebeale/save-hidden-field-answers
Draft

WAIT: Save logged_out_only answers for signed-in registrants#1840
maebeale wants to merge 1 commit into
mainfrom
maebeale/save-hidden-field-answers

Conversation

@maebeale

Copy link
Copy Markdown
Collaborator

What is the goal of this PR and why is this important?

  • When a signed-in registrant has identity/contact data on file, those logged_out_only fields are hidden from the registration form, so their answers were never recorded on the submission — leaving an incomplete snapshot that looked like the registrant skipped questions.
  • This records that on-file data as form answers so each registration is a complete snapshot, and makes the field-hiding rule consistent with the bulk-payment form.

How did you approach the change?

  • Added a PersonKnownFields PORO that maps a person's on-file identity/contact data to the registration form's logged_out_only field identifiers, and PublicRegistration now backfills those values onto the submission for signed-in registrants (skipping confirm_email, blanks, and anything the registrant actually submitted).
  • Changed PublicRegistrationsController to hide all logged_out_only fields for signed-in users (matching the bulk-payment rule) instead of only the ones we already had answers for, with a temporary exception keeping the Organization Information (agency_*) fields visible until they can be backfilled from affiliations.

UI Testing Checklist

  • As a signed-in registrant, the identity/contact fields you already have on file are hidden, but the Organization Information section still shows.
  • After submitting, the saved registration shows answers for those hidden fields populated from your profile data.
  • As a logged-out registrant, every field still renders as before.

Anything else to add?

  • The Organization carve-out is intentionally temporary; once org data is backfilled from person.affiliations.active, the agency_* exception in hide_logged_out_only_fields comes out.
  • The scholarship-form rendering still applies no logged_out_only filter — left untouched in this PR.

@maebeale maebeale changed the title Save logged_out_only answers for signed-in registrants WAIT: Save logged_out_only answers for signed-in registrants Jun 22, 2026
@maebeale maebeale force-pushed the maebeale/save-hidden-field-answers branch from abc6a84 to 032c577 Compare June 22, 2026 11:33
A signed-in registrant's identity/contact fields are hidden from the
registration form once we have them on file, so those answers were never
recorded on the submission — leaving an incomplete snapshot that made the
saved registration look like the registrant skipped questions they didn't
actually need to answer.

Record the known values onto the submission via the new PersonKnownFields
PORO, and align the hide rule with the bulk-payment form: hide every
logged_out_only field for signed-in users regardless of what's on file,
with a temporary exception for the Organization Information fields (kept
visible until we can backfill them from the person's affiliations).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@maebeale maebeale force-pushed the maebeale/save-hidden-field-answers branch from 032c577 to 6b6b33a Compare June 22, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant