WAIT: Save logged_out_only answers for signed-in registrants#1840
Draft
maebeale wants to merge 1 commit into
Draft
WAIT: Save logged_out_only answers for signed-in registrants#1840maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
abc6a84 to
032c577
Compare
A signed-in registrant's identity/contact fields are hidden from the registration form once we have them on file, so those answers were never recorded on the submission — leaving an incomplete snapshot that made the saved registration look like the registrant skipped questions they didn't actually need to answer. Record the known values onto the submission via the new PersonKnownFields PORO, and align the hide rule with the bulk-payment form: hide every logged_out_only field for signed-in users regardless of what's on file, with a temporary exception for the Organization Information fields (kept visible until we can backfill them from the person's affiliations). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
032c577 to
6b6b33a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
logged_out_onlyfields are hidden from the registration form, so their answers were never recorded on the submission — leaving an incomplete snapshot that looked like the registrant skipped questions.How did you approach the change?
PersonKnownFieldsPORO that maps a person's on-file identity/contact data to the registration form'slogged_out_onlyfield identifiers, andPublicRegistrationnow backfills those values onto the submission for signed-in registrants (skippingconfirm_email, blanks, and anything the registrant actually submitted).PublicRegistrationsControllerto hide alllogged_out_onlyfields for signed-in users (matching the bulk-payment rule) instead of only the ones we already had answers for, with a temporary exception keeping the Organization Information (agency_*) fields visible until they can be backfilled from affiliations.UI Testing Checklist
Anything else to add?
person.affiliations.active, theagency_*exception inhide_logged_out_only_fieldscomes out.logged_out_onlyfilter — left untouched in this PR.