WAIT: Add organization status and location filters to registrants list#1839
Draft
maebeale wants to merge 1 commit into
Draft
WAIT: Add organization status and location filters to registrants list#1839maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
Group the registrants filters into a card with two rows so the growing set of controls stays scannable, and surface filters admins were missing: an Organization status filter (Linked/Pending/None, mirroring the badge logic already shown per row) plus Locality and Country location filters alongside the existing State and County. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
commented
Jun 22, 2026
| end.map(&:id) | ||
| end | ||
|
|
||
| def needs_linking?(registration) |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Overlap is intentional — a registration with a linked org and a non-matching submitted agency name counts as both Linked and Pending, matching the per-row badges. Each filter option returns everyone in that state rather than a single exclusive bucket.
maebeale
commented
Jun 22, 2026
| expect(response.body).to include(">Pending<") | ||
| expect(response.body).not_to include(">None<") | ||
| expect(response.body).to include("<span>Pending</span>") | ||
| expect(response.body).not_to include("<span>None</span>") |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Tightened from >None< to the exact chip markup because the new Organization status dropdown legitimately renders a "None"/"Pending" <option>, which would otherwise match this assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
The event registrants filter bar had grown unwieldy and was missing controls admins need to triage registrants by how their organization is resolved and where they live.
How did you approach the change?
Grouped the filters into a card with two rows (keyword · organization status · scholarship · payment · attendance, then state · locality · county · country), added an Organization status filter (Linked/Pending/None) backed by the new
EventOrganizationLinkStatusPORO that mirrors the per-row badge logic, and added Locality and Country location filters via newEventRegistrationscopes and anEventDashboard#localitiesoption source.UI Testing Checklist
Anything else to add?
The Linked/Pending/None states intentionally overlap (a registration can be both linked and pending), so each option returns everyone matching that state. Covered by model, service, dashboard, and request specs.