Repository navigation
fix(node): fire input event when selecting an option - #334
Merged
Merged
Conversation
route
force-pushed
the
fix/select-input-event
branch
from
October 14, 2026 19:00
9d8c03e to
f09e18a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223.
Node#select_option/Node#unselect_optiondispatched onlychangeon the<select>, soinputlisteners (Stimulus, Alpine, auto-submitting forms) never ran.inputevent on the select right beforechange, matching what browsers fire per the HTML spec.node.closest("select")so options inside an<optgroup>focus/blur/input the select instead of the optgroup.changestill fires unconditionally, as before, to avoid breaking suites that re-select the current option.