Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/capybara/cuprite/browser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@ def window_handle
end

def window_handles
targets.keys
handles = []
targets.each_pair do |id, target|
handles << id if target.type == "page"
end
handles
end

def within_window(locator = nil)
Expand Down
20 changes: 20 additions & 0 deletions spec/features/driver_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -989,6 +989,26 @@ def create_screenshot(file, *args)
expect(@driver.window_handles.size).to eq(2)
end

it "does not count worker targets as windows" do
worker = 'new Worker(URL.createObjectURL(new Blob(["self.onmessage = () => {}"], { type: "text/javascript" })))'
@session.visit "/"
@session.execute_script(worker)
sleep 0.1

expect(@driver.window_handles.size).to eq(1)

popup = @session.window_opened_by do
@session.execute_script <<~JS
const popup = window.open("about:blank")
popup.eval('#{worker}')
JS
sleep 0.1
end

expect(@driver.window_handles.size).to eq(2)
@session.within_window(popup) { expect(@session.current_url).to eq("about:blank") }
end

context "a new window inherits settings" do
it "inherits size" do
@session.visit "/"
Expand Down
Loading