Namespace Timeout Ractor storage internally - #122
Closed
OskarEichler wants to merge 1 commit into
Closed
Conversation
eregon
reviewed
Aug 30, 2026
| # 2. Method object can be shareable (4.0~) | ||
| def self.instance | ||
| Ractor.store_if_absent :timeout_gem_state do | ||
| Ractor.store_if_absent :"\0timeout_gem_state" do |
Member
There was a problem hiding this comment.
That's not really any more private.
Member
|
@OskarEichler Please double-check yourself the usefulness of such PRs before submitting them, to avoid spamming maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeout currently stores its shared state under the public symbol :timeout_gem_state. Unrelated code can preclaim that key and break Timeout initialization. Use an internal Ractor storage key so public-key collisions cannot replace the state. The current suite passes 284 tests / 636 assertions in cumulative verification on Ruby 4.0.6 and 3.2.11; a bounded public-key preclaim model fails baseline in 5/5 runs and passes the candidate in 5/5. No repository tests were changed.