Skip to content

Delete some unused internal methods - #9827

Draft
issyl0 wants to merge 6 commits into
ruby:masterfrom
issyl0:rubygems-rm-unused-methods
Draft

Delete some unused internal methods#9827
issyl0 wants to merge 6 commits into
ruby:masterfrom
issyl0:rubygems-rm-unused-methods

Conversation

@issyl0

@issyl0 issyl0 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

What was the end-user or developer problem that led to this PR?

  • Less code to maintain is a good thing.

What is your fix for the problem, implemented in this PR?

  • Delete some methods that have been unused and/or broken for years.
  • See commits for full details.

Make sure the following tasks are checked

issyl0 added 6 commits August 30, 2026 17:32
@issyl0
Delete Gem::AvailableSet#{to_request_set,inject_into_list}
cf8c0de 
- `to_request_set` has been unused since
  7e35930 in 2014.
- `inject_into_list` has been unused since
  544c3dc in 2019.
@issyl0
Delete Gem::DependencyInstaller#install_development_deps
9526339 
- This was only ever an argument to `AvailableSet#to_request_set`,
  and 7e35930 in 2014 removed both.
@issyl0
Delete `Gem::DependencyList#{remove_specs_unsatisfied_by,spec_predece…
01e1ee4 
…ssors}`

- `remove_specs_unsatisfied_by` has been unused since
  544c3dc in 2019.
- `spec_predecessors` has been unused since
  4cd3f98 in 2008.
@issyl0
Delete Gem::Command#merge_options
c70729d 
- The final use of this - `install_command.merge_options(options)` - was
  removed in 497ae9a in 2008.
@issyl0
Delete Gem::Commands::SourcesCommand#remove_cache_file
648d573 
- This was used in four places until
  736ba62 in 2011.
@issyl0
Delete Gem::Resolver::DependencyRequest#implicit?
c16614b 
- This was added in 49270ff in 2013
  alongside `explicit?`, but never used anywhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@issyl0