create_certs.sh: Unify RSA and ML-DSA-65 SSL cert generation#9678
Open
junaruga wants to merge 2 commits into
Open
create_certs.sh: Unify RSA and ML-DSA-65 SSL cert generation#9678junaruga wants to merge 2 commits into
junaruga wants to merge 2 commits into
Conversation
a385ae8 to
bd6c992
Compare
Merge create_mldsa65_certs.sh into create_certs.sh, removing duplicated logic between create_certs.sh and create_mldsa65_certs.sh files. * Create create_ssl_certs function with genpkey_args and prefix arguments to manage common logic between RSA and ML-DSA-65. * Use "openssl genpkey" instead of "openssl genrsa" for RSA key generation. * Don't use openssl.cnf any more. * Create temporary files under tmp/create_certs/ * Remove tool/create_mldsa65_certs.sh as its logic is now in create_certs.sh Assisted-by: Claude:claude-opus-4-6[1m]
…certs.sh Note that previous "openssl ca" commands did output human-readable text + PEM format for the following files. With new openssl commands, the human readable texts are removed. This is not a problem. ``` test/rubygems/ca_cert.pem test/rubygems/client.pem test/rubygems/ssl_cert.pem ``` Assisted-by: Claude:claude-opus-4-6[1m]
bd6c992 to
5e98341
Compare
Member
Author
|
Note that I confirmed that RSA 2048 bits CA/Server/Client certificate and key files by the following openssl commands. |
Member
Author
|
@hsbt This PR is ready to be reviewed. Could you review the PR? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge create_mldsa65_certs.sh into create_certs.sh, removing duplicated logic
between create_certs.sh and create_mldsa65_certs.sh files.
arguments to manage common logic between RSA and ML-DSA-65.
create_certs.sh
The 1st commit is the refactoring for the
create_mldsa65_certs.shandcreate_certs.sh.The 2nd commit is to upgrade SSL/TLS RSA test/rubygems/*.pem files generated by new
create_certs.sh.Note that previous "openssl ca" commands did output human-readable text + PEM format.
With new openssl commands, the human readable texts are removed.
This is not a problem.
Assisted-by: Claude:claude-opus-4-6[1m]
What was the end-user or developer problem that led to this PR?
tool/create_certs.shandtool/create_mldsa65_certs.shhas duplicated logic for each other. This situation is not convenient when managing the files and adding new algorithms.What is your fix for the problem, implemented in this PR?
Merged tool/create_mldsa65_certs.sh into tool/create_certs.sh, removing duplicated logic.
Make sure the following tasks are checked