Repository navigation
Disable CPU pinning when ractor harness is used - #557
Merged
Merged
Conversation
By default ruby-bench pins all benchmarks to a single core using taskset for benchmark consistency. When the ractor benchmarks are run with --category=ractor or --category=ractor-only, we disable CPU pinning because the purpose of the ractor benchmarks is to test concurrent code. We weren't disabling CPU pinning when individual benchmarks are being run with --harness=ractor or when running a benchmark whos default harness is the ractor harness. This PR makes every benchmark that runs with the ractor harness disable CPU pinning.
luke-gruber
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default ruby-bench pins all benchmarks to a single core using taskset for benchmark consistency.
When the ractor benchmarks are run with --category=ractor or --category=ractor-only, we disable CPU pinning because the purpose of the ractor benchmarks is to test concurrent code.
We weren't disabling CPU pinning when individual benchmarks are being run with --harness=ractor or when running a benchmark whos default harness is the ractor harness.
This PR makes every benchmark that runs with the ractor harness disable CPU pinning.