Conversation
Documentation previewCommit: |
skatkov
changed the title
skatkov
changed the title
skatkov
changed the title
skatkov
marked this pull request as ready for review
September 26, 2026 23:22
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
File mutations can leave the completed page index stale, returning missing or removed pages.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Finalizes RubyGems-parsed stores and aligns page indexing with the parse-then-complete lifecycle introduced after PR #1811.
Changes:
- Calls
Store#completefrom the RubyGems hook. - Builds page indexes during
completeorload_all. - Updates lifecycle and cross-reference tests.
| File | Description |
|---|---|
lib/rdoc/rubygems_hook.rb |
Finalizes the parsed store before generation. |
lib/rdoc/store.rb |
Moves page-index construction into finalization/loading. |
test/rdoc/rdoc_store_test.rb |
Updates page-index lifecycle tests. |
test/rdoc/rdoc_rubygems_hook_test.rb |
Tests visibility and :nodoc: finalization. |
test/rdoc/rdoc_cross_reference_test.rb |
Finalizes fixtures before page resolution. |
test/rdoc/markup/to_html_crossref_test.rb |
Finalizes cross-reference fixtures. |
test/rdoc/generator/markup_test.rb |
Finalizes generator fixtures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
skatkov
force-pushed
the
store-complete
branch
from
September 27, 2026 17:06
042e903 to
d5ed8ea
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1811 (comment)
#completeis ran in rubygems hooks, this sets proper filter and nocode marks.