Strip markdown HTML comments within paragraph#1698
Open
tompng wants to merge 1 commit intoruby:masterfrom
Open
Strip markdown HTML comments within paragraph#1698tompng wants to merge 1 commit intoruby:masterfrom
tompng wants to merge 1 commit intoruby:masterfrom
Conversation
Standalone HTML comments is converted to RDoc::Markup::Raw. However, HTML comments in a paragraph were not handled correctly. Since RDoc paragraph can't contain Raw, inline HTML comments should be stripped. HTML comments in a paragraph "\n<!-- -->\n" will generate double newline "\n\n", so ToHtml also needs to handle this double newline.
tompng
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
Collaborator
|
🚀 Preview deployment available at: https://d3cb0ca4.rdoc-6cd.pages.dev (commit: 9037f7b) |
st0012
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone HTML comments is converted to
RDoc::Markup::Raw. However, HTML comments in a paragraph were not handled correctly.Since RDoc paragraph can't contain Raw, inline HTML comments should be stripped. HTML comments in a paragraph
"\n<!-- -->\n"will generate double newline"\n\n", so ToHtml also needs to handle this double newline.Fix this markdown comment rendering
Before
After