Open
Conversation
Collaborator
|
🚀 Preview deployment available at: https://82707249.rdoc-6cd.pages.dev (commit: 0706cd1) |
st0012
force-pushed
the
fix-blockquote-lazy-continuation
branch
from
1959fd1 to
d658309
Compare
st0012
force-pushed
the
fix-blockquote-lazy-continuation
branch
4 times, most recently
from
6f54b65 to
c168d42
Compare
st0012
changed the title
st0012
changed the title
st0012
force-pushed
the
fix-blockquote-lazy-continuation
branch
from
c168d42 to
3d620eb
Compare
Two changes to the BlockQuoteRaw rule in the PEG grammar: 1. Stop lazy continuation from consuming block-level elements by adding negative lookaheads for headings, list markers, and code fences. 2. End blockquotes at unquoted blank lines. Previously, all blank lines were consumed and the parser continued matching subsequent > lines as part of the same blockquote. Now only blank lines prefixed with > continue the blockquote, matching GFM where an unquoted blank line separates two distinct blockquotes.
st0012
force-pushed
the
fix-blockquote-lazy-continuation
branch
from
3d620eb to
0706cd1
Compare
st0012
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to the
BlockQuoteRawrule in the PEG grammar:>continue the blockquote, so an unquoted blank line ends it.Ref: #1550 (comment)